Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0051526

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

major

have not tried

2023-02-01 12:56

2023-03-13 17:59

Reporter

njimenez

View Status

public

Assigned To

njimenez

Priority

normal

Resolution

fixed

Fixed in Version

23Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0051526: Cashup and initial count are not taken into account when difference limit is zero

Description

When a payment method or an orgarnization is configured to show an approval when the difference specified in cashup or initial count are grater than the provided amount, it does not work if the specified amount is zero.

Steps To Reproduce

1. Configure a payment method with count difference limit zero
2. Configure at least one action reason for validate count and advance user action
2. Go to the POS
3. Open the main menu and select close till option
4. On count step insert an amount greater than zero
5. See how the approval reasons dialog is not shown

Proposed Solution

Attached a fix with the proposed solution it should be accompanied by a test case in PaymentMethodValidations.test.js

Tags

No tags attached.

fix.diff [^] (1,005 bytes) 2023-02-01 13:11 [Show Content] [Hide Content]

diff --git a/web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js b/web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js
index c1007df20..15edd6b30 100644
--- a/web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js
+++ b/web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js
@@ -140,8 +140,8 @@ function organizationLimitExceeded(
   organizationDifferenceLimit
 ) {
   return (
-    organizationDifferenceLimit &&
-    !paymentMethodDifferenceLimit &&
+    organizationDifferenceLimit != null &&
+    paymentMethodDifferenceLimit == null &&
     Math.abs(paymentMethodDifference) >= organizationDifferenceLimit
   );
 }
@@ -153,7 +153,7 @@ function paymentMethodLimitExceeded(
   paymentMethodDifference,
   paymentMethodDifferenceLimit
 ) {
-  return paymentMethodDifferenceLimit
+  return paymentMethodDifferenceLimit != null
     ? Math.abs(paymentMethodDifference) >= paymentMethodDifferenceLimit
     : false;
 }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

feature request

closed

Action Reasons in Open till and Cashup with differences

Notes
(0147173) hgbot (developer) 2023-03-01 13:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1562 [^]

(0147500) hgbot (developer) 2023-03-13 17:59	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1562 [^]

(0147501) hgbot (developer) 2023-03-13 17:59	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: fc2e82887dd7d4029857fb66439c0b86055f2b06 Author: Natalia Jimenez <natalia.jimenez@openbravo.com> Date: 13-03-2023 16:59:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fc2e82887dd7d4029857fb66439c0b86055f2b06 [^] Fixed BUG-51526: Cashup and initial count difference limit wrongly checked when limit is 0 --- M web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js M web-jspack/org.openbravo.pos2/src/model/cashup/__test__/PaymentMethodValidations.test.js ---

Issue History
Date Modified	Username	Field	Change
2023-02-01 12:56	njimenez	New Issue
2023-02-01 12:56	njimenez	Assigned To	=> Retail
2023-02-01 12:56	njimenez	Triggers an Emergency Pack	=> No
2023-02-01 13:03	caristu	Relationship added	related to 0051249
2023-02-01 13:11	caristu	Proposed Solution updated
2023-02-01 13:11	caristu	File Added: fix.diff
2023-03-01 09:57	njimenez	Assigned To	Retail => njimenez
2023-03-01 13:48	hgbot	Note Added: 0147173
2023-03-13 17:59	hgbot	Note Added: 0147500
2023-03-13 17:59	hgbot	Resolution	open => fixed
2023-03-13 17:59	hgbot	Status	new => closed
2023-03-13 17:59	hgbot	Fixed in Version	=> 23Q2
2023-03-13 17:59	hgbot	Note Added: 0147501

Copyright © 2000 - 2009 MantisBT Group