Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051526POS2POSpublic2023-02-01 12:562023-03-13 17:59
Reporternjimenez 
Assigned Tonjimenez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051526: Cashup and initial count are not taken into account when difference limit is zero
DescriptionWhen a payment method or an orgarnization is configured to show an approval when the difference specified in cashup or initial count are grater than the provided amount, it does not work if the specified amount is zero.
Steps To Reproduce1. Configure a payment method with count difference limit zero
2. Configure at least one action reason for validate count and advance user action
2. Go to the POS
3. Open the main menu and select close till option
4. On count step insert an amount greater than zero
5. See how the approval reasons dialog is not shown
Proposed SolutionAttached a fix with the proposed solution it should be accompanied by a test case in PaymentMethodValidations.test.js
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0051249 closed njimenez Action Reasons in Open till and Cashup with differences 
Attached Filesdiff fix.diff (1,005) 2023-02-01 13:11
https://issues.openbravo.com/file_download.php?file_id=18088&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-02-01 12:56njimenezNew Issue
2023-02-01 12:56njimenezAssigned To => Retail
2023-02-01 12:56njimenezTriggers an Emergency Pack => No
2023-02-01 13:03caristuRelationship addedrelated to 0051249
2023-02-01 13:11caristuProposed Solution updated
2023-02-01 13:11caristuFile Added: fix.diff
2023-03-01 09:57njimenezAssigned ToRetail => njimenez
2023-03-01 13:48hgbotNote Added: 0147173
2023-03-13 17:59hgbotNote Added: 0147500
2023-03-13 17:59hgbotResolutionopen => fixed
2023-03-13 17:59hgbotStatusnew => closed
2023-03-13 17:59hgbotFixed in Version => 23Q2
2023-03-13 17:59hgbotNote Added: 0147501

Notes
(0147173)
hgbot   
2023-03-01 13:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1562 [^]
(0147500)
hgbot   
2023-03-13 17:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1562 [^]
(0147501)
hgbot   
2023-03-13 17:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fc2e82887dd7d4029857fb66439c0b86055f2b06
Author: Natalia Jimenez <natalia.jimenez@openbravo.com>
Date: 13-03-2023 16:59:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fc2e82887dd7d4029857fb66439c0b86055f2b06 [^]

Fixed BUG-51526: Cashup and initial count difference limit wrongly checked when limit is 0

---
M web-jspack/org.openbravo.pos2/src/model/cashup/PaymentMethodValidations.js
M web-jspack/org.openbravo.pos2/src/model/cashup/__test__/PaymentMethodValidations.test.js
---