Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051525 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Core | major | always | 2023-01-02 12:52 | 2023-02-16 13:30 | |||
| Reporter | javierRodriguez | View Status | public | |||||
| Assigned To | gdagnesses | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 23Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051525: Improve log when a user action is cancelled | |||||||
| Description | When a user action is canceled by the user, it is logged the same way as if the user action failed, see: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js#L230 [^] If the captured exception is an instance of ActionCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionCanceled.js [^]) we should show a different message, and if it is an instance of ActionSilentlyCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionSilentlyCanceled.js [^]) we should show a different message too. Both exceptions should be able to receive an optional message in their constructor. If one of those exceptions contains a message, the message should be included in the message written in the log. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0146614) hgbot (developer) 2023-02-16 09:35 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/472 [^] |
|
(0146616) hgbot (developer) 2023-02-16 09:39 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/980 [^] |
|
(0146618) hgbot (developer) 2023-02-16 09:57 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/206 [^] |
|
(0146620) hgbot (developer) 2023-02-16 09:59 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1529 [^] |
|
(0146623) hgbot (developer) 2023-02-16 11:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/68 [^] |
|
(0146628) hgbot (developer) 2023-02-16 13:26 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/472 [^] |
|
(0146629) hgbot (developer) 2023-02-16 13:26 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 4bbd4466d2df35dd87fa0961b69d4a43c04b846c Author: Guillermo Dagnesses Segura <guillermo.dagnesses@doceleguas.com> Date: 16-02-2023 13:26:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/4bbd4466d2df35dd87fa0961b69d4a43c04b846c [^] Fixed ISSUE-51525: Improve log when a user action is cancelled --- M src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java M web/org.openbravo.mobile.core/app/model/application-state/ActionCanceled.js M web/org.openbravo.mobile.core/app/model/application-state/State.js --- |
|
(0146630) hgbot (developer) 2023-02-16 13:26 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/980 [^] |
|
(0146631) hgbot (developer) 2023-02-16 13:26 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 132239c254dadd68618d79f363408660573d6837 Author: Guillermo Dagnesses Segura <guillermo.dagnesses@doceleguas.com> Date: 16-02-2023 09:38:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/132239c254dadd68618d79f363408660573d6837 [^] Fixed ISSUE-51525: Improve log when a user action is cancelled Whether an action is canceled silently or not, the user action will write terminal log indicating that the action was canceled, with the proper context --- M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowFlowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/model/terminal-log/actions/addUserAction.js --- |
|
(0146632) hgbot (developer) 2023-02-16 13:27 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/68 [^] |
|
(0146633) hgbot (developer) 2023-02-16 13:27 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: 916e1640a7360a1faf73245521d1194c24463962 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 16-02-2023 09:40:40 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/916e1640a7360a1faf73245521d1194c24463962 [^] Related to ISSUE-51525: Fixes tests --- M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/SetBusinessDate.test.js --- |
|
(0146634) hgbot (developer) 2023-02-16 13:27 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 15ee257a5d48a9517e540fc97b10227f72e47b83 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 16-02-2023 13:27:27 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/15ee257a5d48a9517e540fc97b10227f72e47b83 [^] Related to ISSUE-51525: Fixes tests --- M web-jspack/org.openbravo.pos2.restaurant/src/model/ticket/user-actions/__test__/FinishProductConfigurationStep.test.js M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/SelectLineHooks.test.js --- |
|
(0146635) hgbot (developer) 2023-02-16 13:27 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/206 [^] |
|
(0146636) hgbot (developer) 2023-02-16 13:30 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 760e8b57c305eaf5babc3b1ed96aa640af4cb7aa Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 16-02-2023 13:30:13 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/760e8b57c305eaf5babc3b1ed96aa640af4cb7aa [^] Related to ISSUE-51525: Fixes tests --- M web-jspack/org.openbravo.pos2/src/components/Service/__test__/FinalMandatoryServicePaymentFlow.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/AddNewProofOfPaymentSelectedLinesUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentDivideEquallyUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentFillInAmountUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/FinishProductConfigurationStep.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenTerminalScheduleUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToCashupWindow.test.js --- |
|
(0146637) hgbot (developer) 2023-02-16 13:30 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1529 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-02-01 11:04 | guilleaer | Type | feature request => backport |
| 2023-02-01 11:04 | guilleaer | Target Version | => 23Q1 |
| 2023-02-02 12:54 | guilleaer | Assigned To | meriem_azaf => gdagnesses |
| 2023-02-16 09:35 | hgbot | Note Added: 0146614 | |
| 2023-02-16 09:39 | hgbot | Note Added: 0146616 | |
| 2023-02-16 09:57 | hgbot | Note Added: 0146618 | |
| 2023-02-16 09:59 | hgbot | Note Added: 0146620 | |
| 2023-02-16 11:45 | hgbot | Note Added: 0146623 | |
| 2023-02-16 13:26 | hgbot | Resolution | open => fixed |
| 2023-02-16 13:26 | hgbot | Status | scheduled => closed |
| 2023-02-16 13:26 | hgbot | Note Added: 0146628 | |
| 2023-02-16 13:26 | hgbot | Fixed in Version | => RR23Q1 |
| 2023-02-16 13:26 | hgbot | Note Added: 0146629 | |
| 2023-02-16 13:26 | hgbot | Note Added: 0146630 | |
| 2023-02-16 13:26 | hgbot | Fixed in Version | RR23Q1 => 23Q1 |
| 2023-02-16 13:26 | hgbot | Note Added: 0146631 | |
| 2023-02-16 13:27 | hgbot | Note Added: 0146632 | |
| 2023-02-16 13:27 | hgbot | Note Added: 0146633 | |
| 2023-02-16 13:27 | hgbot | Note Added: 0146634 | |
| 2023-02-16 13:27 | hgbot | Note Added: 0146635 | |
| 2023-02-16 13:30 | hgbot | Note Added: 0146636 | |
| 2023-02-16 13:30 | hgbot | Note Added: 0146637 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |