Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051274 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] Core | major | always | 2023-01-02 12:52 | 2023-03-06 08:34 | |||
| Reporter | javierRodriguez | View Status | public | |||||
| Assigned To | gdagnesses | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051274: Improve log when a user action is cancelled | |||||||
| Description | When a user action is canceled by the user, it is logged the same way as if the user action failed, see: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js#L230 [^] If the captured exception is an instance of ActionCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionCanceled.js [^]) we should show a different message, and if it is an instance of ActionSilentlyCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionSilentlyCanceled.js [^]) we should show a different message too. Both exceptions should be able to receive an optional message in their constructor. If one of those exceptions contains a message, the message should be included in the message written in the log. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0145797) hgbot (developer) 2023-01-24 15:46 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/463 [^] |
|
(0146136) hgbot (developer) 2023-02-01 16:36 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/974 [^] |
|
(0146141) hgbot (developer) 2023-02-01 19:27 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/67 [^] |
|
(0146142) hgbot (developer) 2023-02-01 19:28 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/202 [^] |
|
(0146167) hgbot (developer) 2023-02-02 13:21 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1500 [^] |
|
(0146170) hgbot (developer) 2023-02-02 14:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: 3688ac85852e17f17131fc53aa97741e5eb39024 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 02-02-2023 13:47:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/3688ac85852e17f17131fc53aa97741e5eb39024 [^] Related to ISSUE-51274: Fixes tests --- M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/SetBusinessDate.test.js --- |
|
(0146171) hgbot (developer) 2023-02-02 14:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/67 [^] |
|
(0146172) hgbot (developer) 2023-02-02 14:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/202 [^] |
|
(0146173) hgbot (developer) 2023-02-02 14:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: b398b083494d6c1dffbed5865bc9f843ddc9bebc Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 02-02-2023 13:46:25 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/b398b083494d6c1dffbed5865bc9f843ddc9bebc [^] Related to ISSUE-51274: Fixes tests --- M web-jspack/org.openbravo.pos2.restaurant/src/model/ticket/user-actions/__test__/FinishProductConfigurationStep.test.js M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/SelectLineHooks.test.js --- |
|
(0146174) hgbot (developer) 2023-02-02 14:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1500 [^] |
|
(0146175) hgbot (developer) 2023-02-02 14:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: cb2c10d3468f110b548948c9b8b6c4ffab1d745e Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 02-02-2023 12:39:19 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cb2c10d3468f110b548948c9b8b6c4ffab1d745e [^] Related to ISSUE-51274: Fixes tests --- M web-jspack/org.openbravo.pos2/src/components/Service/__test__/FinalMandatoryServicePaymentFlow.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/AddNewProofOfPaymentSelectedLinesUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentDivideEquallyUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentFillInAmountUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/FinishProductConfigurationStep.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenTerminalScheduleUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToCashupWindow.test.js --- |
|
(0146176) hgbot (developer) 2023-02-02 14:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/974 [^] |
|
(0146177) hgbot (developer) 2023-02-02 14:29 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 2790803e6a83e03ba0aec4f05009f236d32c8102 Author: Guillermo Dagnesses Segura <guillermo.dagnesses@doceleguas.com> Date: 02-02-2023 14:28:36 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2790803e6a83e03ba0aec4f05009f236d32c8102 [^] Fixed ISSUE-51274: Improve log when a user action is cancelled Whether an action is canceled silently or not, the user action will write terminal log indicating that the action was canceled, with the proper context --- M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowFlowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/model/terminal-log/actions/addUserAction.js --- |
|
(0147283) hgbot (developer) 2023-03-06 08:34 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/463 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-01-02 12:52 | javierRodriguez | New Issue | |
| 2023-01-02 12:52 | javierRodriguez | Assigned To | => javierRodriguez |
| 2023-01-02 12:52 | javierRodriguez | Triggers an Emergency Pack | => No |
| 2023-01-19 17:22 | guilleaer | Assigned To | javierRodriguez => Triage Platform Base |
| 2023-01-20 09:03 | AugustoMauch | Status | new => scheduled |
| 2023-01-20 09:03 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf |
| 2023-01-20 14:42 | AugustoMauch | Summary | Create log when a user action is cancelled => Improve log when a user action is cancelled |
| 2023-01-20 14:42 | AugustoMauch | Description Updated | View Revisions |
| 2023-01-24 15:46 | hgbot | Note Added: 0145797 | |
| 2023-01-24 15:53 | hgbot | Note Added: 0145798 | |
| 2023-02-01 11:04 | guilleaer | Status | scheduled => acknowledged |
| 2023-02-01 11:04 | guilleaer | Status | acknowledged => scheduled |
| 2023-02-01 16:18 | hgbot | Note Added: 0146133 | |
| 2023-02-01 16:36 | hgbot | Note Added: 0146136 | |
| 2023-02-01 19:27 | hgbot | Note Added: 0146141 | |
| 2023-02-01 19:28 | hgbot | Note Added: 0146142 | |
| 2023-02-02 12:53 | guilleaer | Note Deleted: 0145798 | |
| 2023-02-02 12:53 | guilleaer | Note Deleted: 0146133 | |
| 2023-02-02 12:54 | guilleaer | Assigned To | meriem_azaf => gdagnesses |
| 2023-02-02 13:21 | hgbot | Note Added: 0146167 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146170 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146171 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146172 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146173 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146174 | |
| 2023-02-02 14:29 | hgbot | Note Added: 0146175 | |
| 2023-02-02 14:29 | hgbot | Resolution | open => fixed |
| 2023-02-02 14:29 | hgbot | Status | scheduled => closed |
| 2023-02-02 14:29 | hgbot | Note Added: 0146176 | |
| 2023-02-02 14:29 | hgbot | Fixed in Version | => 23Q2 |
| 2023-02-02 14:29 | hgbot | Note Added: 0146177 | |
| 2023-03-06 08:34 | hgbot | Note Added: 0147283 | |
| 2023-06-21 12:59 | alostale | Relationship added | causes 0052814 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |