Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051511 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2023-01-31 00:46 | 2023-02-01 15:52 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051511: RM-4500: [GIFT CARD / CREDIT NOTE] : Scan Credit note bar code at the payment not working | |||||||
| Description | See: https://openbravo.atlassian.net/browse/RM-4500 [^] | |||||||
| Steps To Reproduce | This issue occurs when there is a gift card as well as a credit note button in the payment buttons. The flow: - the scanner changes the UI state, setting a property who's name is retrieved from the paymentprovider instance. - All payment providers use the same payment-state-property name (gcnv_scannedGiftCard). - When the state is changed the paymentbutton will open the giftcarddialogWhat goes wrong - when there are both a credit note and a gift card button in the payment button bar then both will start the payment flow, one will open the dialog, but for both a processing dialog is opened.When then applying the gift card one process dialog is never removed, blocking the user. | |||||||
| Proposed Solution | Solution: a payment button should only open a dialog of the scanned card is of the type of the cards supported by the button (a credit note payment button should only open the dialog when a credit note is scanned). | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0146055) hgbot (developer) 2023-01-31 00:49 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1494 [^] |
|
(0146056) hgbot (developer) 2023-01-31 00:53 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/187 [^] |
|
(0146122) hgbot (developer) 2023-02-01 15:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1494 [^] |
|
(0146123) hgbot (developer) 2023-02-01 15:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f69ce1e21d86b7ff3996cd9492edab395ab0e447 Author: Martin Taal <martin.taal@openbravo.com> Date: 01-02-2023 14:52:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f69ce1e21d86b7ff3996cd9492edab395ab0e447 [^] Fixes ISSUE-51511: allow paymentprovider to control what payment state it can handle --- M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/PaymentProvider.js --- |
|
(0146124) hgbot (developer) 2023-02-01 15:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: bde36ff1715a53b5100d6d93477ff8e09ef2be0f Author: Martin Taal <martin.taal@openbravo.com> Date: 30-01-2023 23:53:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/bde36ff1715a53b5100d6d93477ff8e09ef2be0f [^] Fixes ISSUE-51511: allow paymentprovider to control what payment state it can handle --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/CreditNotePaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GCNVPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCertificatePaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/services/scan/handlers/GiftCardScanEventHandler.js --- |
|
(0146125) hgbot (developer) 2023-02-01 15:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 56ef930a66b9c711a501145a04b952f8ab36adad Author: Martin Taal <martin.taal@openbravo.com> Date: 30-01-2023 23:53:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/56ef930a66b9c711a501145a04b952f8ab36adad [^] Fixes ISSUE-51511: allow paymentprovider to control what payment state it can handle --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/CreditNotePaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCertificatePaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/services/scan/handlers/GiftCardScanEventHandler.js --- |
|
(0146126) hgbot (developer) 2023-02-01 15:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 48c6d62121d55f0a588a16bdb434d7d3f1fc3573 Author: Martin Taal <martin.taal@openbravo.com> Date: 31-01-2023 01:24:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/48c6d62121d55f0a588a16bdb434d7d3f1fc3573 [^] Related to ISSUE-51511: solve typo --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js --- |
|
(0146127) hgbot (developer) 2023-02-01 15:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 876b094a2ca0e858f9783ccf0895722d26247a23 Author: Martin Taal <martin.taal@openbravo.com> Date: 31-01-2023 17:33:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/876b094a2ca0e858f9783ccf0895722d26247a23 [^] Related to ISSUE-51511: implemented grouped payment handling of scanning --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GCNVPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GroupedPaymentProvider.test.js --- |
|
(0146128) hgbot (developer) 2023-02-01 15:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 3607f3001080ef41f2351726026dd17c073f59ac Author: Martin Taal <martin.taal@openbravo.com> Date: 31-01-2023 17:33:35 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/3607f3001080ef41f2351726026dd17c073f59ac [^] Related to ISSUE-51511: implemented grouped payment handling of scanning --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GroupedPaymentProvider.test.js --- |
|
(0146129) hgbot (developer) 2023-02-01 15:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 627490a9d37cbf1389f59723a20144752b0a34ae Author: Martin Taal <martin.taal@openbravo.com> Date: 31-01-2023 23:19:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/627490a9d37cbf1389f59723a20144752b0a34ae [^] Related to ISSUE-51511: solve grouped payment --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js --- |
|
(0146130) hgbot (developer) 2023-02-01 15:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/187 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-01-31 00:46 | mtaal | New Issue | |
| 2023-01-31 00:46 | mtaal | Assigned To | => mtaal |
| 2023-01-31 00:46 | mtaal | Triggers an Emergency Pack | => No |
| 2023-01-31 00:49 | hgbot | Note Added: 0146055 | |
| 2023-01-31 00:53 | hgbot | Note Added: 0146056 | |
| 2023-01-31 09:16 | rafaroda | Relationship added | related to 0051285 |
| 2023-01-31 09:16 | rafaroda | Relationship added | related to 0051391 |
| 2023-02-01 15:52 | hgbot | Resolution | open => fixed |
| 2023-02-01 15:52 | hgbot | Status | new => closed |
| 2023-02-01 15:52 | hgbot | Note Added: 0146122 | |
| 2023-02-01 15:52 | hgbot | Fixed in Version | => 23Q2 |
| 2023-02-01 15:52 | hgbot | Note Added: 0146123 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146124 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146125 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146126 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146127 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146128 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146129 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146130 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |