Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0051511 | POS2 | POS | public | 2023-01-31 00:46 | 2023-02-01 15:52 |
|
| Reporter | mtaal | |
| Assigned To | mtaal | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 23Q2 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0051511: RM-4500: [GIFT CARD / CREDIT NOTE] : Scan Credit note bar code at the payment not working |
| Description | See:
https://openbravo.atlassian.net/browse/RM-4500 [^] |
| Steps To Reproduce | This issue occurs when there is a gift card as well as a credit note button in the payment buttons. The flow:
- the scanner changes the UI state, setting a property who's name is retrieved from the paymentprovider instance.
- All payment providers use the same payment-state-property name (gcnv_scannedGiftCard).
- When the state is changed the paymentbutton will open the giftcarddialogWhat goes wrong
- when there are both a credit note and a gift card button in the payment button bar then both will start the payment flow, one will open the dialog, but for both a processing dialog is opened.When then applying the gift card one process dialog is never removed, blocking the user. |
| Proposed Solution |
Solution: a payment button should only open a dialog of the scanned card is of the type of the cards supported by the button (a credit note payment button should only open the dialog when a credit note is scanned). |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0051285 | | closed | Retail | When paying by credit note, iif we scan a barcode of credit note, the credit note is not found | | related to | defect | 0051391 | | closed | ruben_jimenez | FLUN-3481: Regression 23Q1 - impossible to pay with credit note |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-01-31 00:46 | mtaal | New Issue | |
| 2023-01-31 00:46 | mtaal | Assigned To | => mtaal |
| 2023-01-31 00:46 | mtaal | Triggers an Emergency Pack | => No |
| 2023-01-31 00:49 | hgbot | Note Added: 0146055 | |
| 2023-01-31 00:53 | hgbot | Note Added: 0146056 | |
| 2023-01-31 09:16 | rafaroda | Relationship added | related to 0051285 |
| 2023-01-31 09:16 | rafaroda | Relationship added | related to 0051391 |
| 2023-02-01 15:52 | hgbot | Resolution | open => fixed |
| 2023-02-01 15:52 | hgbot | Status | new => closed |
| 2023-02-01 15:52 | hgbot | Note Added: 0146122 | |
| 2023-02-01 15:52 | hgbot | Fixed in Version | => 23Q2 |
| 2023-02-01 15:52 | hgbot | Note Added: 0146123 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146124 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146125 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146126 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146127 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146128 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146129 | |
| 2023-02-01 15:52 | hgbot | Note Added: 0146130 | |
|
Notes |
|
|
(0146055)
|
|
hgbot
|
|
2023-01-31 00:49
|
|
|
|
|
(0146056)
|
|
hgbot
|
|
2023-01-31 00:53
|
|
|
|
|
(0146122)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146123)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146124)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: bde36ff1715a53b5100d6d93477ff8e09ef2be0f
Author: Martin Taal <martin.taal@openbravo.com>
Date: 30-01-2023 23:53:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/bde36ff1715a53b5100d6d93477ff8e09ef2be0f [^]
Fixes ISSUE-51511: allow paymentprovider to control what payment state it can handle
---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/CreditNotePaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GCNVPaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCertificatePaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GroupedPaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/services/scan/handlers/GiftCardScanEventHandler.js
---
|
|
|
|
(0146125)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146126)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146127)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146128)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146129)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|
|
|
(0146130)
|
|
hgbot
|
|
2023-02-01 15:52
|
|
|