Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051428
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2023-01-20 13:052023-02-17 10:25
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in VersionRR23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051428: Empty changes are propagated from backbone to the state

DescriptionWhen a change is done in a backbone property ignored in the state, the state update is fired even if there are no real changes
Steps To Reproduce1) Apply the attached patch into mobile.core modules. It adds a couple of test cases.
2) Run the test, note the test that modifies an ignored backbone property fails.
TagsNo tags attached.
Attached Filesdiff file icon test.diff [^] (693 bytes) 2023-01-20 13:47 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0051176 closedTriage Omni WMS Modules AWO offline state and persistance 
causes defect 0051640 closedcaristu Retail Modules Cannot reset the state of a state backward compatibility model to an empty object 

-  Notes
(0145689)
hgbot (developer)
2023-01-20 13:50

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/462 [^]
(0145729)
hgbot (developer)
2023-01-23 09:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 3af4960908426c1b8d04e0f557beed2786a076c7
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 23-01-2023 09:51:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3af4960908426c1b8d04e0f557beed2786a076c7 [^]

fixes BUG-51428: empty changes are propagated from backbone to the state

  Empty changes are propagated from backbone to the state when the value
of an ignored property is changed. This shouldn't fire state changes,
i.e., the setProperties action of the state model should not be invoked
in that case.

---
M web-test/model/application-state/compat/StateBackwardCompatibility-infra.test.js
M web/org.openbravo.mobile.core/source/data/StateBackwardCompatibility.js
---
(0145730)
hgbot (developer)
2023-01-23 09:56

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/462 [^]

- Issue History
Date Modified Username Field Change
2023-01-20 13:05 caristu New Issue
2023-01-20 13:05 caristu Assigned To => caristu
2023-01-20 13:05 caristu Triggers an Emergency Pack => No
2023-01-20 13:47 caristu Steps to Reproduce Updated View Revisions
2023-01-20 13:47 caristu File Added: test.diff
2023-01-20 13:50 hgbot Note Added: 0145689
2023-01-23 08:29 caristu Relationship added blocks 0051176
2023-01-23 09:50 caristu Summary Do not propagate empty changes from backbone to the state => Empty changes are propagated from backbone to the state
2023-01-23 09:56 hgbot Resolution open => fixed
2023-01-23 09:56 hgbot Status new => closed
2023-01-23 09:56 hgbot Fixed in Version => RR23Q2
2023-01-23 09:56 hgbot Note Added: 0145729
2023-01-23 09:56 hgbot Note Added: 0145730
2023-02-17 10:25 caristu Issue cloned 0051640
2023-02-17 10:36 caristu Relationship added causes 0051640

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker