Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051428Retail ModulesWeb POSpublic2023-01-20 13:052023-02-17 10:25
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051428: Empty changes are propagated from backbone to the state
DescriptionWhen a change is done in a backbone property ignored in the state, the state update is fired even if there are no real changes
Steps To Reproduce1) Apply the attached patch into mobile.core modules. It adds a couple of test cases.
2) Run the test, note the test that modifies an ignored backbone property fails.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0051176 closed Triage Omni WMS Modules AWO offline state and persistance 
causes defect 0051640 closed caristu Retail Modules Cannot reset the state of a state backward compatibility model to an empty object 
Attached Filesdiff test.diff (693) 2023-01-20 13:47
https://issues.openbravo.com/file_download.php?file_id=18047&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-01-20 13:05caristuNew Issue
2023-01-20 13:05caristuAssigned To => caristu
2023-01-20 13:05caristuTriggers an Emergency Pack => No
2023-01-20 13:47caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25431#r25431
2023-01-20 13:47caristuFile Added: test.diff
2023-01-20 13:50hgbotNote Added: 0145689
2023-01-23 08:29caristuRelationship addedblocks 0051176
2023-01-23 09:50caristuSummaryDo not propagate empty changes from backbone to the state => Empty changes are propagated from backbone to the state
2023-01-23 09:56hgbotResolutionopen => fixed
2023-01-23 09:56hgbotStatusnew => closed
2023-01-23 09:56hgbotFixed in Version => RR23Q2
2023-01-23 09:56hgbotNote Added: 0145729
2023-01-23 09:56hgbotNote Added: 0145730
2023-02-17 10:25caristuIssue cloned0051640
2023-02-17 10:36caristuRelationship addedcauses 0051640

Notes
(0145689)
hgbot   
2023-01-20 13:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/462 [^]
(0145729)
hgbot   
2023-01-23 09:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 3af4960908426c1b8d04e0f557beed2786a076c7
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 23-01-2023 09:51:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3af4960908426c1b8d04e0f557beed2786a076c7 [^]

fixes BUG-51428: empty changes are propagated from backbone to the state

  Empty changes are propagated from backbone to the state when the value
of an ignored property is changed. This shouldn't fire state changes,
i.e., the setProperties action of the state model should not be invoked
in that case.

---
M web-test/model/application-state/compat/StateBackwardCompatibility-infra.test.js
M web/org.openbravo.mobile.core/source/data/StateBackwardCompatibility.js
---
(0145730)
hgbot   
2023-01-23 09:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/462 [^]