Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051415
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2023-01-19 15:472023-01-27 08:29
ReporteralostaleView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051415: Product Media performs always full refresh

DescriptionWhen executing an incremental refresh, Product Media performs a full refresh retrieving media for all products regardless they were updated.
Steps To ReproduceIn an instance with product media defined:

1. Log in pos2
2. Execute Refresh Masterdata (to ensure next refresh should fetch no rows)
3. Execute Refresh Masterdata
  Check developers tools > Network Panel
    Expected: request to ProductMedia masterdata returns no rows
    Obtained: it contains the whole dataset
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0050767 closedguillermogil Retail Modules Product Media Logic in WebPOS 
related to defect 0051434 closedranjith_qualiantech_com Retail Modules API change: ProductMediaProperties was present in root package 
depends on backport 005142123Q1 closedranjith_qualiantech_com POS2 Product Media performs always full refresh 

-  Notes
(0145708)
hgbot (developer)
2023-01-23 07:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/119 [^]
(0145710)
hgbot (developer)
2023-01-23 07:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1043 [^]
(0145901)
marvintm (manager)
2023-01-27 08:15

 As part of this issue we are fixing several problems in the ProductMedia project:
- Pagination will now be done correctly
- Incremental refresh will be handled properly
- The Active property has been added to the API so that images can be disabled if needed
- Proper filtering will be done in the query
(0145902)
hgbot (developer)
2023-01-27 08:15

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1043 [^]
(0145903)
hgbot (developer)
2023-01-27 08:15

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9ee10c1a1bfe14e675d84635b03ae0a7b04954ea
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 07:15:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9ee10c1a1bfe14e675d84635b03ae0a7b04954ea [^]

Fixed ISSUE-51415: Updated ProductMedia query for incrementalRefresh
* Updated ProductMedia query by adding OrgCriteria, incrementalUpdateCriteria,
  paginationCriteria and orderby clause
* Added active and sequenceNumber property to ProductMediaProperties

---
A src/org/openbravo/retail/posterminal/master/ProductMediaProperties.java
M src/org/openbravo/retail/posterminal/master/ProductMedia.java
---
(0145906)
hgbot (developer)
2023-01-27 08:15

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/119 [^]
(0145907)
hgbot (developer)
2023-01-27 08:15

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: d129d41345c4a2431dc9db285c1eea618154b6b9
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 07:15:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/d129d41345c4a2431dc9db285c1eea618154b6b9 [^]

Related to ISSUE-51415: Added active property to ProductMedia mapping

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0145909)
hgbot (developer)
2023-01-27 08:29

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d70dbaa993f3fed1f3a5c0dbdeb4d38455d0f9e5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 12:53:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d70dbaa993f3fed1f3a5c0dbdeb4d38455d0f9e5 [^]

Related to ISSUE-51415: Updated OrderBy clause for ProductMedia query
* If paginationByIdCriteria is present, then query should ordered by id only

---
M src/org/openbravo/retail/posterminal/master/ProductMedia.java
---

- Issue History
Date Modified Username Field Change
2023-01-19 15:47 alostale New Issue
2023-01-19 15:47 alostale Assigned To => Triage Platform Base
2023-01-19 15:47 alostale Triggers an Emergency Pack => No
2023-01-19 15:47 alostale Assigned To Triage Platform Base => Retail
2023-01-19 15:47 alostale Category Core => POS
2023-01-19 15:48 alostale Relationship added related to 0050767
2023-01-20 06:14 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-01-20 06:32 ranjith_qualiantech_com Status new => scheduled
2023-01-20 06:59 ranjith_qualiantech_com Status scheduled => acknowledged
2023-01-20 07:25 marvintm Status acknowledged => scheduled
2023-01-23 07:35 ranjith_qualiantech_com Relationship added related to 0051434
2023-01-23 07:58 hgbot Note Added: 0145708
2023-01-23 07:58 hgbot Note Added: 0145710
2023-01-27 08:15 marvintm Note Added: 0145901
2023-01-27 08:15 hgbot Resolution open => fixed
2023-01-27 08:15 hgbot Status scheduled => closed
2023-01-27 08:15 hgbot Fixed in Version => RR23Q2
2023-01-27 08:15 hgbot Note Added: 0145902
2023-01-27 08:15 hgbot Note Added: 0145903
2023-01-27 08:15 hgbot Note Added: 0145906
2023-01-27 08:15 hgbot Note Added: 0145907
2023-01-27 08:29 hgbot Note Added: 0145909

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker