Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051415POS2POSpublic2023-01-19 15:472023-01-27 08:29
Reporteralostale 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051415: Product Media performs always full refresh
DescriptionWhen executing an incremental refresh, Product Media performs a full refresh retrieving media for all products regardless they were updated.
Steps To ReproduceIn an instance with product media defined:

1. Log in pos2
2. Execute Refresh Masterdata (to ensure next refresh should fetch no rows)
3. Execute Refresh Masterdata
  Check developers tools > Network Panel
    Expected: request to ProductMedia masterdata returns no rows
    Obtained: it contains the whole dataset
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0050767 closed guillermogil Retail Modules Product Media Logic in WebPOS 
related to defect 0051434 closed ranjith_qualiantech_com Retail Modules API change: ProductMediaProperties was present in root package 
depends on backport 005142123Q1 closed ranjith_qualiantech_com POS2 Product Media performs always full refresh 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-19 15:47alostaleNew Issue
2023-01-19 15:47alostaleAssigned To => Triage Platform Base
2023-01-19 15:47alostaleOBNetwork customer => No
2023-01-19 15:47alostaleTriggers an Emergency Pack => No
2023-01-19 15:47alostaleAssigned ToTriage Platform Base => Retail
2023-01-19 15:47alostaleCategoryCore => POS
2023-01-19 15:48alostaleRelationship addedrelated to 0050767
2023-01-20 06:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-01-20 06:32ranjith_qualiantech_comStatusnew => scheduled
2023-01-20 06:59ranjith_qualiantech_comStatusscheduled => acknowledged
2023-01-20 07:25marvintmStatusacknowledged => scheduled
2023-01-23 07:35ranjith_qualiantech_comRelationship addedrelated to 0051434
2023-01-23 07:58hgbotMerge Request Status => open
2023-01-23 07:58hgbotNote Added: 0145708
2023-01-23 07:58hgbotNote Added: 0145710
2023-01-27 08:15marvintmNote Added: 0145901
2023-01-27 08:15hgbotMerge Request Statusopen => approved
2023-01-27 08:15hgbotResolutionopen => fixed
2023-01-27 08:15hgbotStatusscheduled => closed
2023-01-27 08:15hgbotFixed in Version => RR23Q2
2023-01-27 08:15hgbotNote Added: 0145902
2023-01-27 08:15hgbotNote Added: 0145903
2023-01-27 08:15hgbotNote Added: 0145906
2023-01-27 08:15hgbotNote Added: 0145907
2023-01-27 08:29hgbotNote Added: 0145909

Notes
(0145708)
hgbot   
2023-01-23 07:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/119 [^]
(0145710)
hgbot   
2023-01-23 07:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1043 [^]
(0145901)
marvintm   
2023-01-27 08:15   
As part of this issue we are fixing several problems in the ProductMedia project:
- Pagination will now be done correctly
- Incremental refresh will be handled properly
- The Active property has been added to the API so that images can be disabled if needed
- Proper filtering will be done in the query
(0145902)
hgbot   
2023-01-27 08:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1043 [^]
(0145903)
hgbot   
2023-01-27 08:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9ee10c1a1bfe14e675d84635b03ae0a7b04954ea
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 07:15:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9ee10c1a1bfe14e675d84635b03ae0a7b04954ea [^]

Fixed ISSUE-51415: Updated ProductMedia query for incrementalRefresh
* Updated ProductMedia query by adding OrgCriteria, incrementalUpdateCriteria,
  paginationCriteria and orderby clause
* Added active and sequenceNumber property to ProductMediaProperties

---
A src/org/openbravo/retail/posterminal/master/ProductMediaProperties.java
M src/org/openbravo/retail/posterminal/master/ProductMedia.java
---
(0145906)
hgbot   
2023-01-27 08:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/119 [^]
(0145907)
hgbot   
2023-01-27 08:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: d129d41345c4a2431dc9db285c1eea618154b6b9
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 07:15:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/d129d41345c4a2431dc9db285c1eea618154b6b9 [^]

Related to ISSUE-51415: Added active property to ProductMedia mapping

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0145909)
hgbot   
2023-01-27 08:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d70dbaa993f3fed1f3a5c0dbdeb4d38455d0f9e5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 12:53:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d70dbaa993f3fed1f3a5c0dbdeb4d38455d0f9e5 [^]

Related to ISSUE-51415: Updated OrderBy clause for ProductMedia query
* If paginationByIdCriteria is present, then query should ordered by id only

---
M src/org/openbravo/retail/posterminal/master/ProductMedia.java
---