Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051248
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POScriticalalways2022-12-27 09:572023-07-14 15:00
Reporterphilippe_muiView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in Version23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - Confirmed Stable
Regression date2022-11-02
Regression introduced in release23Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c1080c23ce8ebaf46a1b5e0aedd7d5c46082ea80 [^]
Triggers an Emergency PackNo
Summary

0051248: Bug checkbox when adding a service or alteration

DescriptionHi,

Access to WEBPOS
select a product and add service
click on service icon and try select (or not) checkboxs (see video)

Current result : Unable to select checkboxs, except the “all” box. If no checkbox is checked, the service interface is opened with the store page

Expected result : Can select a checkbox . If no checkbox is checked, the service interface must be closed

Best regards,
Steps To ReproduceAccess to WEBPOS
select a product and add service
click on service icon and try select (or not) checkboxs (see video)
Proposed SolutionExpected result : Can select a checkbox . If no checkbox is checked, the service interface must be closed.

TagsFASH
Attached Files? file icon Untitled 116.mp4 [^] (3,305,353 bytes) 2022-12-27 09:57

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0050284 closedAaron_Alvarez [SALES] - Gift card - #Missing configuration when assigning a customer to the ticket during gift card creation 

-  Notes
(0152098)
gorka_gil (administrator)
2023-07-04 11:40

 Disscused with Cristian about an approach to make extensible the disable of ticket actions for specific flows.

The idea was to include in teh state.UI.currentWindow.context a property disableTicketActions.

If this property it is set it should disable TicketBPButton.jsx and TicketLines.jsx.

So in this MR https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1304/diffs [^] search for isProductConfiguration and change to areTicketActionsDisabled

And define:
   const areTicketActionsDisabled = useSelector(
    state => state.UI.currentWindow?.context?.disableTicketActions
  );

Then in giftcards needs to set this property, maybe can be set as property in the payload of the navigation, since it is already setting the product and the ticketLines, it should be just add one more property.

This change maybe breaks some tests, that would be needed to addapt.
(0152180)
hgbot (developer)
2023-07-07 07:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/251 [^]
(0152181)
hgbot (developer)
2023-07-07 07:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1941 [^]
(0152505)
hgbot (developer)
2023-07-14 15:00

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: fe1f7b24bdde70105a5483ab038b7a9542907443
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 14-07-2023 16:57:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/fe1f7b24bdde70105a5483ab038b7a9542907443 [^]

Related to ISSUE-51248: Update currentWindow context when adding giftcard product
* TicketActions should be disabled when adding giftcard product.
  So, currentWindow context is updated with status of disableTicketActions and
  TicketActions are updated using the currentWindow context

---
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/AddProductPostHook.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
---
(0152506)
hgbot (developer)
2023-07-14 15:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/251 [^]
(0152507)
hgbot (developer)
2023-07-14 15:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1941 [^]
(0152508)
hgbot (developer)
2023-07-14 15:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7553cecfac5a1144b075c9bbd9e0c5df040d55e7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 14-07-2023 17:01:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7553cecfac5a1144b075c9bbd9e0c5df040d55e7 [^]

Fixed ISSUE-51248: Ticket action should be disabled based on window context
* If State currentWindow context have disableTicketAction status,
  then ticketBP and ticketLines should be updated with disable status

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.jsx
---

- Issue History
Date Modified Username Field Change
2022-12-27 09:57 philippe_mui New Issue
2022-12-27 09:57 philippe_mui Assigned To => Retail
2022-12-27 09:57 philippe_mui File Added: Untitled 116.mp4
2022-12-27 09:57 philippe_mui Triggers an Emergency Pack => No
2022-12-27 09:58 philippe_mui Tag Attached: FASH
2023-06-26 15:48 AugustoMauch Proposed Solution updated
2023-06-26 15:49 AugustoMauch Assigned To Retail => meriem_azaf
2023-06-28 10:25 AugustoMauch Severity minor => major
2023-06-28 10:55 AugustoMauch Proposed Solution updated
2023-06-28 12:22 meriem_azaf Status new => acknowledged
2023-06-28 12:22 meriem_azaf Status acknowledged => scheduled
2023-06-30 10:44 AugustoMauch Regression level => Production - Confirmed Stable
2023-06-30 10:44 AugustoMauch Regression date => 2022-11-02
2023-06-30 10:44 AugustoMauch Regression introduced in release => 23Q1
2023-06-30 10:44 AugustoMauch Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/780292a0fdb56ae3ffdc1e7dc3321954cf3cf8ce [^]
2023-06-30 10:44 AugustoMauch Priority normal => immediate
2023-06-30 10:44 AugustoMauch Severity major => critical
2023-06-30 10:45 AugustoMauch Regression introduced by commit https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/780292a0fdb56ae3ffdc1e7dc3321954cf3cf8ce [^] => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c1080c23ce8ebaf46a1b5e0aedd7d5c46082ea80 [^]
2023-06-30 10:46 AugustoMauch Assigned To meriem_azaf => gorka_gil
2023-06-30 10:48 AugustoMauch Relationship added caused by 0050284
2023-07-04 11:40 gorka_gil Note Added: 0152098
2023-07-04 11:40 gorka_gil Assigned To gorka_gil => ranjith_qualiantech_com
2023-07-07 07:02 hgbot Note Added: 0152180
2023-07-07 07:02 hgbot Note Added: 0152181
2023-07-07 10:27 gorka_gil Issue Monitored: gorka_gil
2023-07-14 15:00 hgbot Note Added: 0152505
2023-07-14 15:00 hgbot Note Added: 0152506
2023-07-14 15:00 hgbot Note Added: 0152507
2023-07-14 15:00 hgbot Resolution open => fixed
2023-07-14 15:00 hgbot Status scheduled => closed
2023-07-14 15:00 hgbot Fixed in Version => 23Q4
2023-07-14 15:00 hgbot Note Added: 0152508

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker