Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050284
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2022-09-19 16:372022-11-02 15:47
ReporternoemierousselView Statuspublic 
Assigned ToAaron_Alvarez 
PriorityhighResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Togorka_gil
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050284: [SALES] - Gift card - #Missing configuration when assigning a customer to the ticket during gift card creation

DescriptionWhen adding a product “Gift card” to a ticket, and assigning the ticket to an identified customer, the gift card is automatically closed with #Missing configuration without letting the user finishing the flow of gift card creation.
Steps To Reproduce1-Go to the WebPOS

2-Add product "Gift Card to the ticket"

3-Assign the gift card to a customer

4-Do not finish fulfil the other fields such as gift card identifier or gift card amount, and assign the ticket to an identified customer

5-The gift card is added with #Missing configuration to the ticket, and has been automatically closed. -> KO
Proposed SolutionCurrent result: The gift card is closed, added to the ticket with the label #Missing Configuration when assigning an identified customer to the ticket during the process of gift card creation

Expected result: The gift card is not automatically finished, and the user can continue to fulfil the gift card creation fields after having assigned the identified customer to the ticket
TagsFASH
Attached Filespng file icon test gift card.png [^] (37,444 bytes) 2022-09-19 16:37

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0051248 closedranjith_qualiantech_com Bug checkbox when adding a service or alteration 

-  Notes
(0142463)
hgbot (developer)
2022-10-24 14:04

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1304 [^]
(0142611)
hgbot (developer)
2022-10-26 18:25

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c1080c23ce8ebaf46a1b5e0aedd7d5c46082ea80
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 16:25:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c1080c23ce8ebaf46a1b5e0aedd7d5c46082ea80 [^]

Related to ISSUE-50284: In GiftCard configuration, the ticket lines and BP are blocked

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.jsx
---
(0142612)
hgbot (developer)
2022-10-26 18:25

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 68fe007bbcad0dab2787ad095d9478fb1d3385a8
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 16:25:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/68fe007bbcad0dab2787ad095d9478fb1d3385a8 [^]

Related to ISSUE-50284: Revert "Fixed ISSUE-49860: Customer selector should be rendered based on user action"

This reverts commit c4dc4b553d64b80f5e9ef65a5e6bff4e794726e6.
With the current fixes, the issue 49860 is no longer reproducible,
because the change bp is now blocked during gift card creation.

Also the fix for the issue 49860 was breaking the automatic open of customer selector when adding the filter.

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerFormSelector/CustomerFormSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButtonGeneric.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetShowCustomerSelector.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetShowCustomerSelector.js
---
(0142613)
hgbot (developer)
2022-10-26 18:25

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1304 [^]
(0142615)
hgbot (developer)
2022-10-26 18:25

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8734c28a562700b66ace630a46c38e6a553fc0ca
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 16:25:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8734c28a562700b66ace630a46c38e6a553fc0ca [^]

Related to ISSUE-50284: Revert workaround after revert the fix for the ISSUE-49860

The fix was breaking the auto bp selector launch

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/viewOrdersOfCustomer.spec.js
---
(0142618)
hgbot (developer)
2022-10-26 18:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/161 [^]
(0142619)
hgbot (developer)
2022-10-26 18:33

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 38fea686d962219f05b7783b9287267c7a263a05
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 18:30:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/38fea686d962219f05b7783b9287267c7a263a05 [^]

Related to ISSUE-50284: Revert "Related to ISSUE-49860: Customer selector should be rendered based on user action"

This reverts commit d86d3dc20088fd852e7f4cd504ac9715deeea144.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
---
(0142621)
hgbot (developer)
2022-10-26 18:33

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/161 [^]
(0142816)
hgbot (developer)
2022-11-02 15:47

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 780292a0fdb56ae3ffdc1e7dc3321954cf3cf8ce
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 02-11-2022 15:47:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/780292a0fdb56ae3ffdc1e7dc3321954cf3cf8ce [^]

Related to ISSUE-50284: Rename function isProductConfiguration to isProductConfigurationFlow

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.jsx
---

- Issue History
Date Modified Username Field Change
2022-09-19 16:37 noemieroussel New Issue
2022-09-19 16:37 noemieroussel Assigned To => Retail
2022-09-19 16:37 noemieroussel File Added: test gift card.png
2022-09-19 16:37 noemieroussel Triggers an Emergency Pack => No
2022-09-19 16:37 noemieroussel Tag Attached: FASH
2022-09-19 16:38 noemieroussel Steps to Reproduce Updated View Revisions
2022-10-17 13:42 gorka_gil Assigned To Retail => Aaron_Alvarez
2022-10-24 14:04 hgbot Note Added: 0142463
2022-10-26 18:25 hgbot Note Added: 0142611
2022-10-26 18:25 hgbot Note Added: 0142612
2022-10-26 18:25 hgbot Note Added: 0142613
2022-10-26 18:25 hgbot Note Added: 0142615
2022-10-26 18:32 hgbot Note Added: 0142618
2022-10-26 18:33 hgbot Note Added: 0142619
2022-10-26 18:33 hgbot Note Added: 0142621
2022-10-26 19:18 gorka_gil Status new => scheduled
2022-10-26 19:19 gorka_gil Status scheduled => resolved
2022-10-26 19:19 gorka_gil Fixed in Version => 23Q1
2022-10-26 19:19 gorka_gil Resolution open => fixed
2022-10-26 19:19 gorka_gil Review Assigned To => gorka_gil
2022-10-26 19:19 gorka_gil Status resolved => closed
2022-11-02 15:47 hgbot Note Added: 0142816
2023-06-30 10:48 AugustoMauch Relationship added causes 0051248

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker