0051191: In some cases Abort Product Configuration confirmation popup does not allow do do a correct translation

Description

Abort Product Configuration confirmation popup does not allow do do a correct translation

The problem is the following:

Translating to french

cancel is translated to Annuler

  <row id="32360CCD780547EB9E2610F3D38BE46E" trl="Y">
    <value column="MsgText" isTrl="Y" original="Cancel">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>

abort → Annuler

  <row id="E9A9F7E825AB4025805763BE7616CA4D" trl="Y">
    <value column="MsgText" isTrl="Y" original="Abort">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>

In this specific context it leads in a dialog with 2 buttons with the same text

To properly define a specific text for this flow I suggest to use a specific label for OK/Cancel instead of using the generic one by adding a new parameter to the dialog and changing the one for OK
(https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/a5f744b3b228691ad1daa2c97d52788fe8b84c8e/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js#L37 [^])

confirmLabel: '$OBPOS2_ConfirmCancellationOfProductConfiguration'
cancelLabel: '$OBPOS2_StopCancellationOfProductConfiguration'

This messages in english will remain as “cancel”/"abort" but we will allow to change it for other languages.

in french someone should find the proper word to describe the action to “cancel” the “abort” and "confirm" the abort

Steps To Reproduce

Assign a modifier to a product in POS2 and try to "Abort" it

Proposed Solution

Previos fix is not enough because the flow is different when adding and modifying. Currently the flow of modifying is working fine but not adding

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0144792) hgbot (developer) 2022-12-18 12:29	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1421 [^]

(0144799) hgbot (developer) 2022-12-19 08:40	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1421 [^]

(0144800) hgbot (developer) 2022-12-19 08:40	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: a345d8a4b2dc4462f06be0a267462636fc2f576f Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com> Date: 18-12-2022 12:22:25 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a345d8a4b2dc4462f06be0a267462636fc2f576f [^] fixed ISSUE-51191: Abort Product Configuration confirmation popup does not allow do do a correct translation --- M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AbortProductConfiguration.js ---

Issue History
Date Modified	Username	Field	Change
2022-12-18 12:14	guilleaer	New Issue
2022-12-18 12:14	guilleaer	Assigned To	=> ebecerra
2022-12-18 12:14	guilleaer	OBNetwork customer	=> No
2022-12-18 12:14	guilleaer	Triggers an Emergency Pack	=> No
2022-12-18 12:14	guilleaer	Issue generated from	0050764
2022-12-18 12:15	guilleaer	Assigned To	ebecerra => guilleaer
2022-12-18 12:16	guilleaer	Status	new => acknowledged
2022-12-18 12:21	guilleaer	Status	acknowledged => scheduled
2022-12-18 12:29	hgbot	Merge Request Status	=> open
2022-12-18 12:29	hgbot	Note Added: 0144792
2022-12-19 08:40	hgbot	Merge Request Status	open => approved
2022-12-19 08:40	hgbot	Resolution	open => fixed
2022-12-19 08:40	hgbot	Status	scheduled => closed
2022-12-19 08:40	hgbot	Note Added: 0144799
2022-12-19 08:40	hgbot	Fixed in Version	=> 23Q1
2022-12-19 08:40	hgbot	Note Added: 0144800