Openbravo Issue Tracking System - POS2
View Issue Details
0051191POS2Restaurantspublic2022-12-18 12:142022-12-19 08:40
guilleaer 
guilleaer 
normalminorhave not tried
closedfixed 
5
 
23Q1 
No
0051191: In some cases Abort Product Configuration confirmation popup does not allow do do a correct translation
Abort Product Configuration confirmation popup does not allow do do a correct translation

The problem is the following:

Translating to french

cancel is translated to Annuler

  <row id="32360CCD780547EB9E2610F3D38BE46E" trl="Y">
    <value column="MsgText" isTrl="Y" original="Cancel">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>
 

abort → Annuler

  <row id="E9A9F7E825AB4025805763BE7616CA4D" trl="Y">
    <value column="MsgText" isTrl="Y" original="Abort">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>
 

In this specific context it leads in a dialog with 2 buttons with the same text

To properly define a specific text for this flow I suggest to use a specific label for OK/Cancel instead of using the generic one by adding a new parameter to the dialog and changing the one for OK
(https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/a5f744b3b228691ad1daa2c97d52788fe8b84c8e/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js#L37 [^])

confirmLabel: '$OBPOS2_ConfirmCancellationOfProductConfiguration'
cancelLabel: '$OBPOS2_StopCancellationOfProductConfiguration'

This messages in english will remain as “cancel”/"abort" but we will allow to change it for other languages.

in french someone should find the proper word to describe the action to “cancel” the “abort” and "confirm" the abort
Assign a modifier to a product in POS2 and try to "Abort" it
Previos fix is not enough because the flow is different when adding and modifying. Currently the flow of modifying is working fine but not adding
No tags attached.
Issue History
2022-12-18 12:14guilleaerNew Issue
2022-12-18 12:14guilleaerAssigned To => ebecerra
2022-12-18 12:14guilleaerTriggers an Emergency Pack => No
2022-12-18 12:14guilleaerIssue generated from0050764
2022-12-18 12:15guilleaerAssigned Toebecerra => guilleaer
2022-12-18 12:16guilleaerStatusnew => acknowledged
2022-12-18 12:21guilleaerStatusacknowledged => scheduled
2022-12-18 12:29hgbotNote Added: 0144792
2022-12-19 08:40hgbotResolutionopen => fixed
2022-12-19 08:40hgbotStatusscheduled => closed
2022-12-19 08:40hgbotNote Added: 0144799
2022-12-19 08:40hgbotFixed in Version => 23Q1
2022-12-19 08:40hgbotNote Added: 0144800

Notes
(0144792)
hgbot   
2022-12-18 12:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1421 [^]
(0144799)
hgbot   
2022-12-19 08:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1421 [^]
(0144800)
hgbot   
2022-12-19 08:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a345d8a4b2dc4462f06be0a267462636fc2f576f
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 18-12-2022 12:22:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a345d8a4b2dc4462f06be0a267462636fc2f576f [^]

fixed ISSUE-51191: Abort Product Configuration confirmation popup does not allow do do a correct translation

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AbortProductConfiguration.js
---