Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051070 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2022-12-05 15:58 | 2022-12-14 10:15 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051070: Review and probably remove obsolete buildvalidation DuplicatedPosTerminalPaymentType | |||||||
| Description | This buildvalidation was added in issue 25464 in RMP31 release. It was added to check for conflicting data for a new unique constraint also added in that same issue / release. That means that the buildvalidation is not useful to ran for any release >RMP31. As if the update to RMP31 has been applied successfully that new unique constraint was added. If that worked there cannot be any conflicting data by definition. Note: Ideally that buildvalidation should have gotten an ExecutionLimit.end-version=RMP31 when it was added but that was missed back then. Now with blocker issue 51068 guaranteing that no old direct update is possible anymore we should double check the reasoning given here and likely just remove that build-validation. | |||||||
| Steps To Reproduce | Check reasoning given here against code in that build-validation. | |||||||
| Proposed Solution | Remove it as obsolete (given that depended-on issue 51068 is merged before) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0144423) hgbot (developer) 2022-12-05 16:16 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1008 [^] |
|
(0144648) hgbot (developer) 2022-12-14 10:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1008 [^] |
|
(0144649) hgbot (developer) 2022-12-14 10:15 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: bfb9a210dbae6a21d0f992779f73358784e475e6 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 14-12-2022 09:11:57 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bfb9a210dbae6a21d0f992779f73358784e475e6 [^] Fixes ISSUE-51070. Remove obsolete buildvalidation DuplicatedPosTerminalPaymentType This buildvalidation was added in issue 25464 (RMP31 release) as check for conflicting data for a new unique constraint also added in the same issue. That means it is not useful to run after having updated to that version and having added the db constraint, however that check (ExecutionLimit.endversion<=RMP31) was missed to be added back then. Now with 51068 issue ensuring no direct updates from such old releases are possible we can remove the buildvalidation as obsolete. --- R build/classes/org/openbravo/retail/posterminal/buildvalidation/DuplicatedPosTerminalPaymentType.class R build/classes/org/openbravo/retail/posterminal/buildvalidation/DuplicatedPosTerminalPaymentTypeData.class R src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedPosTerminalPaymentType.java R src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedPosTerminalPaymentType_data.xsql --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-12-05 15:58 | shuehner | New Issue | |
| 2022-12-05 15:58 | shuehner | Assigned To | => shuehner |
| 2022-12-05 15:58 | shuehner | Triggers an Emergency Pack | => No |
| 2022-12-05 15:59 | shuehner | Relationship added | depends on 0051068 |
| 2022-12-05 15:59 | shuehner | Relationship added | related to 0025464 |
| 2022-12-05 16:16 | hgbot | Note Added: 0144423 | |
| 2022-12-14 10:15 | hgbot | Resolution | open => fixed |
| 2022-12-14 10:15 | hgbot | Status | new => closed |
| 2022-12-14 10:15 | hgbot | Note Added: 0144648 | |
| 2022-12-14 10:15 | hgbot | Fixed in Version | => RR23Q1 |
| 2022-12-14 10:15 | hgbot | Note Added: 0144649 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |