Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051070Retail ModulesWeb POSpublic2022-12-05 15:582022-12-14 10:15
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051070: Review and probably remove obsolete buildvalidation DuplicatedPosTerminalPaymentType
DescriptionThis buildvalidation was added in issue 25464 in RMP31 release.
It was added to check for conflicting data for a new unique constraint also added in that same issue / release.

That means that the buildvalidation is not useful to ran for any release >RMP31.
As if the update to RMP31 has been applied successfully that new unique constraint was added.
If that worked there cannot be any conflicting data by definition.

Note:
Ideally that buildvalidation should have gotten an ExecutionLimit.end-version=RMP31 when it was added but that was missed back then.

Now with blocker issue 51068 guaranteing that no old direct update is possible anymore we should double check the reasoning given here and likely just remove that build-validation.
Steps To ReproduceCheck reasoning given here against code in that build-validation.
Proposed SolutionRemove it as obsolete (given that depended-on issue 51068 is merged before)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0025464RMP31 closed marvintm Retail Modules It is possible to define 2 payment types with the same search key 
depends on feature request 0051068PR23Q1 closed shuehner Openbravo ERP Block direct upgrades from version older than 16Q1 to latest version 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-05 15:58shuehnerNew Issue
2022-12-05 15:58shuehnerAssigned To => shuehner
2022-12-05 15:58shuehnerTriggers an Emergency Pack => No
2022-12-05 15:59shuehnerRelationship addeddepends on 0051068
2022-12-05 15:59shuehnerRelationship addedrelated to 0025464
2022-12-05 16:16hgbotNote Added: 0144423
2022-12-14 10:15hgbotResolutionopen => fixed
2022-12-14 10:15hgbotStatusnew => closed
2022-12-14 10:15hgbotNote Added: 0144648
2022-12-14 10:15hgbotFixed in Version => RR23Q1
2022-12-14 10:15hgbotNote Added: 0144649

Notes
(0144423)
hgbot   
2022-12-05 16:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1008 [^]
(0144648)
hgbot   
2022-12-14 10:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1008 [^]
(0144649)
hgbot   
2022-12-14 10:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: bfb9a210dbae6a21d0f992779f73358784e475e6
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 14-12-2022 09:11:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bfb9a210dbae6a21d0f992779f73358784e475e6 [^]

Fixes ISSUE-51070. Remove obsolete buildvalidation DuplicatedPosTerminalPaymentType

This buildvalidation was added in issue 25464 (RMP31 release) as check for conflicting
data for a new unique constraint also added in the same issue.

That means it is not useful to run after having updated to that version
and having added the db constraint, however that check
(ExecutionLimit.endversion<=RMP31) was missed to be added back then.

Now with 51068 issue ensuring no direct updates from such old releases
are possible we can remove the buildvalidation as obsolete.

---
R build/classes/org/openbravo/retail/posterminal/buildvalidation/DuplicatedPosTerminalPaymentType.class
R build/classes/org/openbravo/retail/posterminal/buildvalidation/DuplicatedPosTerminalPaymentTypeData.class
R src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedPosTerminalPaymentType.java
R src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedPosTerminalPaymentType_data.xsql
---