Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051058
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Corecriticalhave not tried2022-11-30 14:302022-12-14 09:07
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in Version22Q3.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051058: Ticket should not be completed if businessPartner is missing

DescriptionIn normal circumstances, businessPartner info is always present but sometimes it is not and this causes the ticket is not removed from the ticket list, even if the payment is completed and the ticket is synchronized with the backoffice, leading to have multiple tickets with the same ID.
Steps To Reproduce- Apply the attached diff to force this error to happen.
- Once logged in to POS2, execute the following in the Chrome developer tools console:

# OB.App.TerminalProperty.get('context').forceFailure = true

- Refresh masterdata
- Add a product to the ticket and complete it. Notice that the ticket is saved in backoffice, but it is still available in the Terminal
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0051041 closedjarmendariz Ticket should not be completed if businessPartner is missing 

-  Notes
(0144371)
hgbot (developer)
2022-12-02 14:20

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1403 [^]
(0144375)
hgbot (developer)
2022-12-02 14:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1006 [^]
(0144400)
hgbot (developer)
2022-12-05 10:39

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86507b1ca33487c60c92559a541ac696eaad072c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 14:31:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86507b1ca33487c60c92559a541ac696eaad072c [^]

Related to ISSUE-51058: Throwing an error when attempting to create a new ticket with no business partner

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/TicketListUtils.js
---
(0144401)
hgbot (developer)
2022-12-05 10:39

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1006 [^]
(0144402)
hgbot (developer)
2022-12-05 10:40

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1403 [^]
(0144403)
hgbot (developer)
2022-12-05 10:40

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5f6d41432744792c8a8e1f07a615195cc27876df
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 14:19:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5f6d41432744792c8a8e1f07a615195cc27876df [^]

Fixed ISSUE-51058: Adding action preparation to ensure ticket is not completed if BP is missing

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
---
(0144561)
hgbot (developer)
2022-12-13 07:41

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1015 [^]
(0144627)
hgbot (developer)
2022-12-14 09:07

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a6d84354cb85386aedebb986606ef64e9b51bda2
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 13-12-2022 12:05:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a6d84354cb85386aedebb986606ef64e9b51bda2 [^]

Related to ISSUE-51058: BP Info should be updated before window is loaded
* BP Info should be updated in OBPOS_LoadPOSWindow hook
  before loading window

---
A web/org.openbravo.retail.posterminal/js/hook/loadPOSWindow.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0144628)
hgbot (developer)
2022-12-14 09:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1015 [^]

- Issue History
Date Modified Username Field Change
2022-12-02 12:20 jarmendariz Type defect => backport
2022-12-02 12:20 jarmendariz Target Version => 22Q3.3
2022-12-02 14:20 hgbot Note Added: 0144371
2022-12-02 14:32 hgbot Note Added: 0144375
2022-12-05 10:39 hgbot Note Added: 0144400
2022-12-05 10:39 hgbot Note Added: 0144401
2022-12-05 10:40 hgbot Resolution open => fixed
2022-12-05 10:40 hgbot Note Added: 0144402
2022-12-05 10:40 hgbot Status scheduled => closed
2022-12-05 10:40 hgbot Fixed in Version => 22Q3.3
2022-12-05 10:40 hgbot Note Added: 0144403
2022-12-13 07:41 hgbot Note Added: 0144561
2022-12-14 09:07 hgbot Note Added: 0144627
2022-12-14 09:07 hgbot Note Added: 0144628

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker