Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051058POS2Corepublic2022-11-30 14:302022-12-14 09:07
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityhighSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version22Q3.3Fixed in Version22Q3.3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051058: Ticket should not be completed if businessPartner is missing
DescriptionIn normal circumstances, businessPartner info is always present but sometimes it is not and this causes the ticket is not removed from the ticket list, even if the payment is completed and the ticket is synchronized with the backoffice, leading to have multiple tickets with the same ID.
Steps To Reproduce- Apply the attached diff to force this error to happen.
- Once logged in to POS2, execute the following in the Chrome developer tools console:

# OB.App.TerminalProperty.get('context').forceFailure = true

- Refresh masterdata
- Add a product to the ticket and complete it. Notice that the ticket is saved in backoffice, but it is still available in the Terminal
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0051041 closed jarmendariz Ticket should not be completed if businessPartner is missing 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-02 12:20jarmendarizTypedefect => backport
2022-12-02 12:20jarmendarizTarget Version => 22Q3.3
2022-12-02 14:20hgbotNote Added: 0144371
2022-12-02 14:32hgbotNote Added: 0144375
2022-12-05 10:39hgbotNote Added: 0144400
2022-12-05 10:39hgbotNote Added: 0144401
2022-12-05 10:40hgbotResolutionopen => fixed
2022-12-05 10:40hgbotNote Added: 0144402
2022-12-05 10:40hgbotStatusscheduled => closed
2022-12-05 10:40hgbotFixed in Version => 22Q3.3
2022-12-05 10:40hgbotNote Added: 0144403
2022-12-13 07:41hgbotNote Added: 0144561
2022-12-14 09:07hgbotNote Added: 0144627
2022-12-14 09:07hgbotNote Added: 0144628

Notes
(0144371)
hgbot   
2022-12-02 14:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1403 [^]
(0144375)
hgbot   
2022-12-02 14:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1006 [^]
(0144400)
hgbot   
2022-12-05 10:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86507b1ca33487c60c92559a541ac696eaad072c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 14:31:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86507b1ca33487c60c92559a541ac696eaad072c [^]

Related to ISSUE-51058: Throwing an error when attempting to create a new ticket with no business partner

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/TicketListUtils.js
---
(0144401)
hgbot   
2022-12-05 10:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1006 [^]
(0144402)
hgbot   
2022-12-05 10:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1403 [^]
(0144403)
hgbot   
2022-12-05 10:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5f6d41432744792c8a8e1f07a615195cc27876df
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 14:19:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5f6d41432744792c8a8e1f07a615195cc27876df [^]

Fixed ISSUE-51058: Adding action preparation to ensure ticket is not completed if BP is missing

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
---
(0144561)
hgbot   
2022-12-13 07:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1015 [^]
(0144627)
hgbot   
2022-12-14 09:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a6d84354cb85386aedebb986606ef64e9b51bda2
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 13-12-2022 12:05:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a6d84354cb85386aedebb986606ef64e9b51bda2 [^]

Related to ISSUE-51058: BP Info should be updated before window is loaded
* BP Info should be updated in OBPOS_LoadPOSWindow hook
  before loading window

---
A web/org.openbravo.retail.posterminal/js/hook/loadPOSWindow.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0144628)
hgbot   
2022-12-14 09:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1015 [^]