Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051026
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2022-11-28 19:122022-12-13 14:14
ReportersofidossantView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket53300
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051026: Allows "Sell Credit" on a return for anonymous business partner

DescriptionAllows "Sell Credit" on a return for the anonymous business partner.
When not configured.
Video: https://www.youtube.com/watch?v=lTQ9uabcmj8&ab_channel=CristianAdrian%7CPracticsBS [^]
Steps To Reproduce1. Open terminal.
2. Do a sales order with anonymous bp.
3. Do a return with the sales order in the step 2
4. When you go a pay, you have the option to Sell Credit.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0028769 closedaaroncalero It is not possible to return a receipt using credit payment method. 

-  Notes
(0144359)
hgbot (developer)
2022-12-02 10:42

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1004 [^]
(0144450)
hgbot (developer)
2022-12-06 09:25

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1004 [^]
(0144451)
hgbot (developer)
2022-12-06 09:25

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a6abbd9e0ed21c50798a420444d0e27dbfbe468f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 06-12-2022 08:17:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a6abbd9e0ed21c50798a420444d0e27dbfbe468f [^]

Fixed ISSUE-51026: SellOnCredit button should not shown for Anonymous customer
* When completing ticket or pay open ticket which has Anonymous customer,
  then SellOnCredit button should be shown based on Pref
  "Web POS Show SellOnCredit for Anonymous Customer"

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0144475)
sofidossant (viewer)
2022-12-07 11:54

 Hi Ranjth

The error continue, A preference has been placed on the generic customer and it happens with any customer who has not configured credit, the button appears on return.

Video: https://youtu.be/9pSst_jVxzw [^]
(0144482)
marvintm (viewer)
2022-12-07 13:12

 This has been fixed in master repo, not in 22Q4, so it makes sense that the problem is still reproducible there.

Just to clarify how this works:
- There is a preference, "Web POS Show SellOnCredit for Anonymous Customer", that must be set to 'N' if you want to restrict the Sell on Credit functionality for the anonymous customer (by default, it is set to 'Y', as we didn't want to change the behavior for current customers).
- If set to 'N', the button will not be shown if the anonymous customer is selected in the ticket, even if it has credit balance.
- The usual restrictions still apply, so if another customer is selected, the button will be shown only if that customer has credit balance.
(0144599)
ngarcia (viewer)
2022-12-13 14:11

 Regarding this comment:

- The usual restrictions still apply, so if another customer is selected, the button will be shown only if that customer has credit balance.

Currently, the button is always shown for returns without taking into account the customer credit balance:

          (order.get('bp').get('creditLimit') > 0 ||
            order.get('bp').get('creditUsed') < 0 ||
            order.getGross() < 0)

- Issue History
Date Modified Username Field Change
2022-11-28 19:12 sofidossant New Issue
2022-11-28 19:12 sofidossant Assigned To => Retail
2022-11-28 19:12 sofidossant OBNetwork customer => OBPS
2022-11-28 19:12 sofidossant Support ticket => 53300
2022-11-28 19:12 sofidossant Triggers an Emergency Pack => No
2022-11-28 19:16 Practics Issue Monitored: Practics
2022-11-29 07:13 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2022-11-30 10:06 ranjith_qualiantech_com Status new => scheduled
2022-12-02 10:42 hgbot Merge Request Status => open
2022-12-02 10:42 hgbot Note Added: 0144359
2022-12-06 09:17 hgbot Merge Request Status open => approved
2022-12-06 09:25 hgbot Resolution open => fixed
2022-12-06 09:25 hgbot Status scheduled => closed
2022-12-06 09:25 hgbot Note Added: 0144450
2022-12-06 09:25 hgbot Fixed in Version => RR23Q1
2022-12-06 09:25 hgbot Note Added: 0144451
2022-12-07 11:53 sofidossant Status closed => new
2022-12-07 11:54 sofidossant Note Added: 0144475
2022-12-07 13:10 marvintm Status new => scheduled
2022-12-07 13:12 marvintm Note Added: 0144482
2022-12-07 13:12 marvintm Status scheduled => resolved
2022-12-07 13:12 marvintm Review Assigned To => marvintm
2022-12-07 13:12 marvintm Status resolved => closed
2022-12-13 14:11 ngarcia Note Added: 0144599
2022-12-13 14:14 ngarcia Relationship added related to 0028769

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker