Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051026Retail ModulesWeb POSpublic2022-11-28 19:122022-12-13 14:14
Reportersofidossant 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR23Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051026: Allows "Sell Credit" on a return for anonymous business partner
DescriptionAllows "Sell Credit" on a return for the anonymous business partner.
When not configured.
Video: https://www.youtube.com/watch?v=lTQ9uabcmj8&ab_channel=CristianAdrian%7CPracticsBS [^]
Steps To Reproduce1. Open terminal.
2. Do a sales order with anonymous bp.
3. Do a return with the sales order in the step 2
4. When you go a pay, you have the option to Sell Credit.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028769 closed aaroncalero It is not possible to return a receipt using credit payment method. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-28 19:12sofidossantNew Issue
2022-11-28 19:12sofidossantAssigned To => Retail
2022-11-28 19:12sofidossantTriggers an Emergency Pack => No
2022-11-28 19:16PracticsIssue Monitored: Practics
2022-11-29 07:13ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-11-30 10:06ranjith_qualiantech_comStatusnew => scheduled
2022-12-02 10:42hgbotNote Added: 0144359
2022-12-06 09:25hgbotResolutionopen => fixed
2022-12-06 09:25hgbotStatusscheduled => closed
2022-12-06 09:25hgbotNote Added: 0144450
2022-12-06 09:25hgbotFixed in Version => RR23Q1
2022-12-06 09:25hgbotNote Added: 0144451
2022-12-07 11:53sofidossantStatusclosed => new
2022-12-07 11:54sofidossantNote Added: 0144475
2022-12-07 13:10marvintmStatusnew => scheduled
2022-12-07 13:12marvintmNote Added: 0144482
2022-12-07 13:12marvintmStatusscheduled => resolved
2022-12-07 13:12marvintmReview Assigned To => marvintm
2022-12-07 13:12marvintmStatusresolved => closed
2022-12-13 14:11ngarciaNote Added: 0144599
2022-12-13 14:14ngarciaRelationship addedrelated to 0028769

Notes
(0144359)
hgbot   
2022-12-02 10:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1004 [^]
(0144450)
hgbot   
2022-12-06 09:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1004 [^]
(0144451)
hgbot   
2022-12-06 09:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a6abbd9e0ed21c50798a420444d0e27dbfbe468f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 06-12-2022 08:17:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a6abbd9e0ed21c50798a420444d0e27dbfbe468f [^]

Fixed ISSUE-51026: SellOnCredit button should not shown for Anonymous customer
* When completing ticket or pay open ticket which has Anonymous customer,
  then SellOnCredit button should be shown based on Pref
  "Web POS Show SellOnCredit for Anonymous Customer"

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0144475)
sofidossant   
2022-12-07 11:54   
Hi Ranjth

The error continue, A preference has been placed on the generic customer and it happens with any customer who has not configured credit, the button appears on return.

Video: https://youtu.be/9pSst_jVxzw [^]
(0144482)
marvintm   
2022-12-07 13:12   
This has been fixed in master repo, not in 22Q4, so it makes sense that the problem is still reproducible there.

Just to clarify how this works:
- There is a preference, "Web POS Show SellOnCredit for Anonymous Customer", that must be set to 'N' if you want to restrict the Sell on Credit functionality for the anonymous customer (by default, it is set to 'Y', as we didn't want to change the behavior for current customers).
- If set to 'N', the button will not be shown if the anonymous customer is selected in the ticket, even if it has credit balance.
- The usual restrictions still apply, so if another customer is selected, the button will be shown only if that customer has credit balance.
(0144599)
ngarcia   
2022-12-13 14:11   
Regarding this comment:

- The usual restrictions still apply, so if another customer is selected, the button will be shown only if that customer has credit balance.

Currently, the button is always shown for returns without taking into account the customer credit balance:

          (order.get('bp').get('creditLimit') > 0 ||
            order.get('bp').get('creditUsed') < 0 ||
            order.getGross() < 0)