Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050921
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2022-11-16 16:272022-11-18 10:12
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in VersionPR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2022-10-31
Regression introduced in releasePR22Q3.2
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050921: Filter in valid tree structure results in message related to cycles in the hierarchy

DescriptionIn this issue [1] we tried to handle properly the filter behaviour when there are cycles in the hierarchy of the data being fetched.

That fix has a bug that results in cycles being detected if the filtered text is present in a child node and one of its ancestors

[1] https://issues.openbravo.com/view.php?id=50549 [^]
Steps To Reproduce- Log in in the openbravo backoffice
- Change to a System Administrator role
- Open the Menu window
- Click the Tree button to show the tree grid view
- In the Name column enter the text "User" (without the quotes). An error related to data cycles is displayed, but there are no cycles in the hierarchy
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0050922PR22Q4.1 closedAugustoMauch Filter in valid tree structure results in message related to cycles in the hierarchy 
depends on backport 0050923PR22Q3.3 closedAugustoMauch Filter in valid tree structure results in message related to cycles in the hierarchy 
caused by defect 0050549 closedAugustoMauch Cycles in entities that represents data as a tree can lead to transaction that does not finish, 100% use of CPU 

-  Notes
(0143726)
hgbot (developer)
2022-11-16 16:31

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/767 [^]
(0143818)
hgbot (developer)
2022-11-18 10:12

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/767 [^]
(0143819)
hgbot (developer)
2022-11-18 10:12

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 30fdff03b714d736f15f860c95b83fda5741e49d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 17-11-2022 20:10:47
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/30fdff03b714d736f15f860c95b83fda5741e49d [^]

Fixes ISSUE-50921: Data cycles are now properly detected in TreeDatasourceService

The problem was that we were not properly checking the presence of data cycles. When filtering a node, we want to include also all its
ancestors. When looking for cycles, instead of looking for repeated nodes in the ancestor list, we were looking for repeated nodes in the
list of nodes that were going to be returned, that contains all the nodes that match the filter plus its ancestors.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---

- Issue History
Date Modified Username Field Change
2022-11-16 16:27 AugustoMauch New Issue
2022-11-16 16:27 AugustoMauch Assigned To => AugustoMauch
2022-11-16 16:27 AugustoMauch Modules => Core
2022-11-16 16:27 AugustoMauch Triggers an Emergency Pack => No
2022-11-16 16:31 hgbot Note Added: 0143726
2022-11-16 16:31 AugustoMauch Relationship added caused by 0050549
2022-11-16 16:32 AugustoMauch Regression level => Production - Confirmed Stable
2022-11-16 16:32 AugustoMauch Regression date => 2022-10-31
2022-11-16 16:32 AugustoMauch Regression introduced in release => PR22Q3.2
2022-11-16 16:32 AugustoMauch Status new => scheduled
2022-11-18 10:12 hgbot Resolution open => fixed
2022-11-18 10:12 hgbot Note Added: 0143818
2022-11-18 10:12 hgbot Status scheduled => closed
2022-11-18 10:12 hgbot Fixed in Version => PR23Q1
2022-11-18 10:12 hgbot Note Added: 0143819


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker