Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050921Openbravo ERPA. Platformpublic2022-11-16 16:272022-11-18 10:12
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2022-10-31
Regression introduced in releasePR22Q3.2
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050921: Filter in valid tree structure results in message related to cycles in the hierarchy
DescriptionIn this issue [1] we tried to handle properly the filter behaviour when there are cycles in the hierarchy of the data being fetched.

That fix has a bug that results in cycles being detected if the filtered text is present in a child node and one of its ancestors

[1] https://issues.openbravo.com/view.php?id=50549 [^]
Steps To Reproduce- Log in in the openbravo backoffice
- Change to a System Administrator role
- Open the Menu window
- Click the Tree button to show the tree grid view
- In the Name column enter the text "User" (without the quotes). An error related to data cycles is displayed, but there are no cycles in the hierarchy
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0050922PR22Q4.1 closed AugustoMauch Filter in valid tree structure results in message related to cycles in the hierarchy 
depends on backport 0050923PR22Q3.3 closed AugustoMauch Filter in valid tree structure results in message related to cycles in the hierarchy 
caused by defect 0050549 closed AugustoMauch Cycles in entities that represents data as a tree can lead to transaction that does not finish, 100% use of CPU 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-16 16:27AugustoMauchNew Issue
2022-11-16 16:27AugustoMauchAssigned To => AugustoMauch
2022-11-16 16:27AugustoMauchModules => Core
2022-11-16 16:27AugustoMauchTriggers an Emergency Pack => No
2022-11-16 16:31hgbotNote Added: 0143726
2022-11-16 16:31AugustoMauchRelationship addedcaused by 0050549
2022-11-16 16:32AugustoMauchRegression level => Production - Confirmed Stable
2022-11-16 16:32AugustoMauchRegression date => 2022-10-31
2022-11-16 16:32AugustoMauchRegression introduced in release => PR22Q3.2
2022-11-16 16:32AugustoMauchStatusnew => scheduled
2022-11-18 10:12hgbotResolutionopen => fixed
2022-11-18 10:12hgbotNote Added: 0143818
2022-11-18 10:12hgbotStatusscheduled => closed
2022-11-18 10:12hgbotFixed in Version => PR23Q1
2022-11-18 10:12hgbotNote Added: 0143819

Notes
(0143726)
hgbot   
2022-11-16 16:31   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/767 [^]
(0143818)
hgbot   
2022-11-18 10:12   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/767 [^]
(0143819)
hgbot   
2022-11-18 10:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 30fdff03b714d736f15f860c95b83fda5741e49d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 17-11-2022 20:10:47
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/30fdff03b714d736f15f860c95b83fda5741e49d [^]

Fixes ISSUE-50921: Data cycles are now properly detected in TreeDatasourceService

The problem was that we were not properly checking the presence of data cycles. When filtering a node, we want to include also all its
ancestors. When looking for cycles, instead of looking for repeated nodes in the ancestor list, we were looking for repeated nodes in the
list of nodes that were going to be returned, that contains all the nodes that match the filter plus its ancestors.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---