Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050825 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Restaurants | minor | have not tried | 2022-11-07 17:55 | 2022-11-14 12:43 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | ebecerra | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q3.3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 22Q3.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050825: Abort Product Configuration confirmation popup does not allow do do a correct translation | |||||||
| Description | Abort Product Configuration confirmation popup does not allow do do a correct translation The problem is the following: Translating to french cancel is translated to Annuler <row id="32360CCD780547EB9E2610F3D38BE46E" trl="Y"> <value column="MsgText" isTrl="Y" original="Cancel">Annuler</value> <value column="MsgTip" isTrl="N" original=""/> </row> abort → Annuler <row id="E9A9F7E825AB4025805763BE7616CA4D" trl="Y"> <value column="MsgText" isTrl="Y" original="Abort">Annuler</value> <value column="MsgTip" isTrl="N" original=""/> </row> In this specific context it leads in a dialog with 2 buttons with the same text To properly define a specific text for this flow I suggest to use a specific label for OK/Cancel instead of using the generic one by adding a new parameter to the dialog and changing the one for OK (https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/a5f744b3b228691ad1daa2c97d52788fe8b84c8e/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js#L37 [^]) confirmLabel: '$OBPOS2_ConfirmCancellationOfProductConfiguration' cancelLabel: '$OBPOS2_StopCancellationOfProductConfiguration' This messages in english will remain as “cancel”/"abort" but we will allow to change it for other languages. in french someone should find the proper word to describe the action to “cancel” the “abort” and "confirm" the abort | |||||||
| Steps To Reproduce | Assign a modifier to a product in POS2 and try to "Abort" it | |||||||
| Proposed Solution | OK/Cancel button in this dialog should not use the generic label. A new one should be created to allow to create a custom translation for this context | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0143380) hgbot (developer) 2022-11-10 12:18 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1354 [^] |
|
(0143557) hgbot (developer) 2022-11-14 12:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1354 [^] |
|
(0143558) hgbot (developer) 2022-11-14 12:43 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0b4e70d2456d0398c568ee40b397afe8ba8e1437 Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com> Date: 14-11-2022 11:43:53 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0b4e70d2456d0398c568ee40b397afe8ba8e1437 [^] Fixes ISSUE-50825: Abort Product Configuration confirmation popup does not... --- M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-11-10 12:10 | guilleaer | Type | defect => backport |
| 2022-11-10 12:10 | guilleaer | Target Version | => 22Q3.3 |
| 2022-11-10 12:18 | hgbot | Note Added: 0143380 | |
| 2022-11-14 12:43 | hgbot | Resolution | open => fixed |
| 2022-11-14 12:43 | hgbot | Status | scheduled => closed |
| 2022-11-14 12:43 | hgbot | Note Added: 0143557 | |
| 2022-11-14 12:43 | hgbot | Fixed in Version | => 22Q3.3 |
| 2022-11-14 12:43 | hgbot | Note Added: 0143558 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |