0050825: Abort Product Configuration confirmation popup does not allow do do a correct translation

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0050825

POS2

Restaurants

public

2022-11-07 17:55

2022-11-14 12:43

Reporter

guilleaer

Assigned To

ebecerra

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

22Q3.3

Fixed in Version

22Q3.3

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0050825: Abort Product Configuration confirmation popup does not allow do do a correct translation

Description

Abort Product Configuration confirmation popup does not allow do do a correct translation

The problem is the following:

Translating to french

cancel is translated to Annuler

  <row id="32360CCD780547EB9E2610F3D38BE46E" trl="Y">
    <value column="MsgText" isTrl="Y" original="Cancel">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>

abort → Annuler

  <row id="E9A9F7E825AB4025805763BE7616CA4D" trl="Y">
    <value column="MsgText" isTrl="Y" original="Abort">Annuler</value>
    <value column="MsgTip" isTrl="N" original=""/>
  </row>

In this specific context it leads in a dialog with 2 buttons with the same text

To properly define a specific text for this flow I suggest to use a specific label for OK/Cancel instead of using the generic one by adding a new parameter to the dialog and changing the one for OK
(https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/a5f744b3b228691ad1daa2c97d52788fe8b84c8e/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js#L37 [^])

confirmLabel: '$OBPOS2_ConfirmCancellationOfProductConfiguration'
cancelLabel: '$OBPOS2_StopCancellationOfProductConfiguration'

This messages in english will remain as “cancel”/"abort" but we will allow to change it for other languages.

in french someone should find the proper word to describe the action to “cancel” the “abort” and "confirm" the abort

Steps To Reproduce

Assign a modifier to a product in POS2 and try to "Abort" it

Proposed Solution

OK/Cancel button in this dialog should not use the generic label. A new one should be created to allow to create a custom translation for this context

Additional Information