Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050713
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsminorhave not tried2022-11-03 07:442022-11-03 12:43
ReportermarvintmView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050713: API Change: New constraints added as part of the merge of the bytotal module

DescriptionAs part of the merge of the bytotal module into the main retail.discounts module, several new constraints have been added:

 <check name="EM_DISCT_TOTALAMOUNTCHK"><![CDATA[M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' AND (EM_DISCT_TOTALAMOUNTDISC IS NOT NULL OR EM_DISCT_ISSCALEDBYTOTAL = 'Y') OR NOT M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15']]></check>
      <check name="EM_DISCT_TOTALPERCCHK"><![CDATA[M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' AND (EM_DISCT_TOTALPERCDISC IS NOT NULL OR EM_DISCT_ISSCALEDBYTOTAL = 'Y') OR NOT M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA']]></check>
      <check name="EM_DISCT_TOTALRECEIPTCHK"><![CDATA[(M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' OR M_OFFER_TYPE_ID = '4755A35B4DA34F6CB08F15462BA123CF') AND EM_DISCT_TOTALRECEIPT IS NOT NULL OR NOT (M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' OR M_OFFER_TYPE_ID = '4755A35B4DA34F6CB08F15462BA123CF') OR EM_DISCT_ISSCALEDBYTOTAL = 'Y' AND (M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA')]]></check>

These constraints did not exist previously in the retail.discounts module, so technically they are an API change. However, they did exist before in the bytotal module, and they essentially apply only when using a bytotal-related discount, so in practice they should be a non-issue for current users.
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0049908 closedranjith_qualiantech_com POS2 Remove incorrect implicit dependency on bytotal module 

-  Notes
(0142850)
hgbot (developer)
2022-11-03 08:14

 Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: 02da1d8cf456108f4888954f38ef4a38929c8510
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 03-11-2022 08:14:52
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/02da1d8cf456108f4888954f38ef4a38929c8510 [^]

Fixed ISSUE-50713: API change, added constraints coming from bytotal module merge

---
M model/modules/org.openbravo.retail.discounts/src-db/database/model/modifiedTables/M_OFFER.xml
---
(0142879)
hgbot (developer)
2022-11-03 12:43

 Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: b4c04ac13470b285c72a751a5db70fb4a999bfde
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 03-11-2022 12:43:36
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/b4c04ac13470b285c72a751a5db70fb4a999bfde [^]

Related to ISSUE-50713: Added missing dbprefix

---
M model/modules/org.openbravo.retail.discounts/src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
---

- Issue History
Date Modified Username Field Change
2022-11-03 07:44 marvintm New Issue
2022-11-03 07:44 marvintm Assigned To => Retail
2022-11-03 07:44 marvintm Triggers an Emergency Pack => No
2022-11-03 07:44 marvintm Relationship added related to 0049908
2022-11-03 07:45 marvintm Summary New constraints added as part of the merge of the bytotal module => API Change: New constraints added as part of the merge of the bytotal module
2022-11-03 08:14 hgbot Resolution open => fixed
2022-11-03 08:14 hgbot Status new => resolved
2022-11-03 08:14 hgbot Note Added: 0142850
2022-11-03 08:15 marvintm Review Assigned To => marvintm
2022-11-03 08:15 marvintm Status resolved => closed
2022-11-03 08:15 marvintm Fixed in Version => RR23Q1
2022-11-03 12:43 hgbot Note Added: 0142879

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker