Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0050713 | Retail Modules | Discounts and Promotions | public | 2022-11-03 07:44 | 2022-11-03 12:43 |
|
| Reporter | marvintm | |
| Assigned To | Retail | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR23Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0050713: API Change: New constraints added as part of the merge of the bytotal module |
| Description | As part of the merge of the bytotal module into the main retail.discounts module, several new constraints have been added:
<check name="EM_DISCT_TOTALAMOUNTCHK"><![CDATA[M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' AND (EM_DISCT_TOTALAMOUNTDISC IS NOT NULL OR EM_DISCT_ISSCALEDBYTOTAL = 'Y') OR NOT M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15']]></check>
<check name="EM_DISCT_TOTALPERCCHK"><![CDATA[M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' AND (EM_DISCT_TOTALPERCDISC IS NOT NULL OR EM_DISCT_ISSCALEDBYTOTAL = 'Y') OR NOT M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA']]></check>
<check name="EM_DISCT_TOTALRECEIPTCHK"><![CDATA[(M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' OR M_OFFER_TYPE_ID = '4755A35B4DA34F6CB08F15462BA123CF') AND EM_DISCT_TOTALRECEIPT IS NOT NULL OR NOT (M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA' OR M_OFFER_TYPE_ID = '4755A35B4DA34F6CB08F15462BA123CF') OR EM_DISCT_ISSCALEDBYTOTAL = 'Y' AND (M_OFFER_TYPE_ID = '4183C8EB7CDA472D9E64521DC2504B15' OR M_OFFER_TYPE_ID = '9707DE71F91549DB80CCB2F094E951EA')]]></check>
These constraints did not exist previously in the retail.discounts module, so technically they are an API change. However, they did exist before in the bytotal module, and they essentially apply only when using a bytotal-related discount, so in practice they should be a non-issue for current users. |
| Steps To Reproduce | . |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | design defect | 0049908 | | closed | ranjith_qualiantech_com | POS2 | Remove incorrect implicit dependency on bytotal module |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-11-03 07:44 | marvintm | New Issue | |
| 2022-11-03 07:44 | marvintm | Assigned To | => Retail |
| 2022-11-03 07:44 | marvintm | Triggers an Emergency Pack | => No |
| 2022-11-03 07:44 | marvintm | Relationship added | related to 0049908 |
| 2022-11-03 07:45 | marvintm | Summary | New constraints added as part of the merge of the bytotal module => API Change: New constraints added as part of the merge of the bytotal module |
| 2022-11-03 08:14 | hgbot | Resolution | open => fixed |
| 2022-11-03 08:14 | hgbot | Status | new => resolved |
| 2022-11-03 08:14 | hgbot | Note Added: 0142850 | |
| 2022-11-03 08:15 | marvintm | Review Assigned To | => marvintm |
| 2022-11-03 08:15 | marvintm | Status | resolved => closed |
| 2022-11-03 08:15 | marvintm | Fixed in Version | => RR23Q1 |
| 2022-11-03 12:43 | hgbot | Note Added: 0142879 | |