Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050627 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-10-25 11:48 | 2023-05-15 14:44 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | dcontrera | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050627: It is not possible to change quantity on Service products | |||||||
| Description | Service products do not allow changing the quantity through the TicketLine Popover buttons, although we may add several of them and are grouped as expected, increasing the quantity. The buttons appear disabled. | |||||||
| Steps To Reproduce | 1. Login WebPOS 2. Add two Basecamp Lantern 3. Try to change the quantity by clicking on the ticket line and the +/- buttons, see that they are disabled. | |||||||
| Proposed Solution | In the file SetLineQuantityButton.js https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/SetLineQuantityButton.jsx#L55 [^] Instead of only checking if the product is configurable, it should be disabled only in the case the configuration rules applied are not marked with forceNewLine = false. Check what was done in AddProductHooks: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js#L48 [^] As you may see, shouldForceNewLine is called to check if we should force or not a new line, if that is false, then we can enable this buttons. | |||||||
| Tags | FASH | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0145468) hgbot (developer) 2023-01-16 23:51 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1468 [^] |
|
(0149312) hgbot (developer) 2023-05-04 18:43 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: eb168d2ca8dac9826ce19a490e2dd21d154e0a37 Author: Dante Contrera <dante.contrera@smfconsulting.es> Date: 04-05-2023 16:43:26 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/eb168d2ca8dac9826ce19a490e2dd21d154e0a37 [^] Fixed ISSUE-50627: Not possible to change qty on service product fixed. --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/SetLineQuantityButton.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/SetLineQuantityButton.test.jsx --- |
|
(0149313) hgbot (developer) 2023-05-04 18:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1468 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-25 11:48 | cberner | New Issue | |
| 2022-10-25 11:48 | cberner | Assigned To | => Retail |
| 2022-10-25 11:48 | cberner | OBNetwork customer | => No |
| 2022-10-25 11:48 | cberner | Triggers an Emergency Pack | => No |
| 2022-10-25 11:50 | rafaroda | OBNetwork customer | No => Gold |
| 2022-10-25 11:50 | rafaroda | Severity | minor => major |
| 2022-10-25 11:50 | rafaroda | Tag Attached: FASH | |
| 2023-01-16 23:51 | hgbot | Merge Request Status | => open |
| 2023-01-16 23:51 | hgbot | Note Added: 0145468 | |
| 2023-01-24 19:42 | dcontrera | Assigned To | Retail => dcontrera |
| 2023-05-04 18:43 | hgbot | Resolution | open => fixed |
| 2023-05-04 18:43 | hgbot | Status | new => resolved |
| 2023-05-04 18:43 | hgbot | Fixed in Version | => 23Q3 |
| 2023-05-04 18:43 | hgbot | Note Added: 0149312 | |
| 2023-05-04 18:43 | hgbot | Merge Request Status | open => merged |
| 2023-05-04 18:43 | hgbot | Note Added: 0149313 | |
| 2023-05-04 18:43 | hgbot | Merge Request Status | merged => approved |
| 2023-05-15 14:44 | javierRodriguez | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |