Openbravo Issue Tracking System - POS2
View Issue Details
0050627POS2POSpublic2022-10-25 11:482023-05-15 14:44
cberner 
dcontrera 
normalmajorhave not tried
closedfixed 
5
 
23Q3 
No
0050627: It is not possible to change quantity on Service products
Service products do not allow changing the quantity through the TicketLine Popover buttons, although we may add several of them and are grouped as expected, increasing the quantity.

The buttons appear disabled.
1. Login WebPOS
2. Add two Basecamp Lantern
3. Try to change the quantity by clicking on the ticket line and the +/- buttons, see that they are disabled.
In the file SetLineQuantityButton.js https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/SetLineQuantityButton.jsx#L55 [^]

Instead of only checking if the product is configurable, it should be disabled only in the case the configuration rules applied are not marked with forceNewLine = false.

Check what was done in AddProductHooks: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js#L48 [^]

As you may see, shouldForceNewLine is called to check if we should force or not a new line, if that is false, then we can enable this buttons.
FASH
Issue History
2022-10-25 11:48cbernerNew Issue
2022-10-25 11:48cbernerAssigned To => Retail
2022-10-25 11:48cbernerTriggers an Emergency Pack => No
2022-10-25 11:50rafarodaSeverityminor => major
2022-10-25 11:50rafarodaTag Attached: FASH
2023-01-16 23:51hgbotNote Added: 0145468
2023-01-24 19:42dcontreraAssigned ToRetail => dcontrera
2023-05-04 18:43hgbotResolutionopen => fixed
2023-05-04 18:43hgbotStatusnew => resolved
2023-05-04 18:43hgbotFixed in Version => 23Q3
2023-05-04 18:43hgbotNote Added: 0149312
2023-05-04 18:43hgbotNote Added: 0149313
2023-05-15 14:44javierRodriguezStatusresolved => closed

Notes
(0145468)
hgbot   
2023-01-16 23:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1468 [^]
(0149312)
hgbot   
2023-05-04 18:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: eb168d2ca8dac9826ce19a490e2dd21d154e0a37
Author: Dante Contrera <dante.contrera@smfconsulting.es>
Date: 04-05-2023 16:43:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/eb168d2ca8dac9826ce19a490e2dd21d154e0a37 [^]

Fixed ISSUE-50627: Not possible to change qty on service product fixed.

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/SetLineQuantityButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/SetLineQuantityButton.test.jsx
---
(0149313)
hgbot   
2023-05-04 18:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1468 [^]