Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2022-09-30 12:592022-10-07 09:24
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050378: Style in Service Provider selector popup filter is wrong

DescriptionThe css style in the Service Provider selector is wrong due to a file that changes all popup filter elements globally. This file should be changed to only modify its own components.

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss#L24 [^]

This should only target its own components and not globally.
Steps To ReproduceConnect to a pos2 with modules, or at least the pos2.service.provider module.
1. Open WebPOS and login
2. Go to Follow-Up Files window, click on Add filters on the top right, and add service provider filter

Check that the top proportions are wrong, shown in two lines instead of one.
Proposed Solutionhttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss#L24 [^] change so it only affects elements in the intended popup.
TagsNo tags attached.
Attached Filespng file icon wrongServiceProviderPopup.png [^] (45,042 bytes) 2022-09-30 12:59

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0141735)
hgbot (developer)
2022-10-06 13:28

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1256 [^]
(0141829)
hgbot (developer)
2022-10-07 09:22

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1256 [^]
(0141830)
hgbot (developer)
2022-10-07 09:22

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c179d152d45b30e236a21ee47333a498c3e8de85
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 07-10-2022 08:55:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c179d152d45b30e236a21ee47333a498c3e8de85 [^]

Fixes ISSUE-50378: Style in Service Provider selector popup filter is wrong

ProductCrossStockList.scss was overwriting one of the styles globally,
instead of only referencing the elements in its popup.

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss
---
(0141831)
hgbot (developer)
2022-10-07 09:24

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 07c0b0a61d605315cc782a9e0c159b6bd7e7cb10
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 07-10-2022 09:23:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/07c0b0a61d605315cc782a9e0c159b6bd7e7cb10 [^]

Related to ISSUE-50378: Align filters in service provider selector to the left, as other popups do

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/ServiceProviderSelector/ServiceProviderSelector.scss
---

- Issue History
Date Modified Username Field Change
2022-09-30 12:59 cberner New Issue
2022-09-30 12:59 cberner Assigned To => Retail
2022-09-30 12:59 cberner File Added: wrongServiceProviderPopup.png
2022-09-30 12:59 cberner Triggers an Emergency Pack => No
2022-10-06 13:27 cberner Assigned To Retail => cberner
2022-10-06 13:27 cberner Status new => scheduled
2022-10-06 13:28 hgbot Note Added: 0141735
2022-10-07 09:22 hgbot Note Added: 0141829
2022-10-07 09:22 hgbot Resolution open => fixed
2022-10-07 09:22 hgbot Status scheduled => closed
2022-10-07 09:22 hgbot Fixed in Version => 23Q1
2022-10-07 09:22 hgbot Note Added: 0141830
2022-10-07 09:24 hgbot Note Added: 0141831


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker