Openbravo Issue Tracking System - POS2
View Issue Details
0050378POS2POSpublic2022-09-30 12:592022-10-07 09:24
cberner 
cberner 
normalminorhave not tried
closedfixed 
5
 
23Q1 
No
0050378: Style in Service Provider selector popup filter is wrong
The css style in the Service Provider selector is wrong due to a file that changes all popup filter elements globally. This file should be changed to only modify its own components.

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss#L24 [^]

This should only target its own components and not globally.
Connect to a pos2 with modules, or at least the pos2.service.provider module.
1. Open WebPOS and login
2. Go to Follow-Up Files window, click on Add filters on the top right, and add service provider filter

Check that the top proportions are wrong, shown in two lines instead of one.
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss#L24 [^] change so it only affects elements in the intended popup.
No tags attached.
png wrongServiceProviderPopup.png (45,042) 2022-09-30 12:59
https://issues.openbravo.com/file_download.php?file_id=17572&type=bug
png
Issue History
2022-09-30 12:59cbernerNew Issue
2022-09-30 12:59cbernerAssigned To => Retail
2022-09-30 12:59cbernerFile Added: wrongServiceProviderPopup.png
2022-09-30 12:59cbernerTriggers an Emergency Pack => No
2022-10-06 13:27cbernerAssigned ToRetail => cberner
2022-10-06 13:27cbernerStatusnew => scheduled
2022-10-06 13:28hgbotNote Added: 0141735
2022-10-07 09:22hgbotNote Added: 0141829
2022-10-07 09:22hgbotResolutionopen => fixed
2022-10-07 09:22hgbotStatusscheduled => closed
2022-10-07 09:22hgbotFixed in Version => 23Q1
2022-10-07 09:22hgbotNote Added: 0141830
2022-10-07 09:24hgbotNote Added: 0141831

Notes
(0141735)
hgbot   
2022-10-06 13:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1256 [^]
(0141829)
hgbot   
2022-10-07 09:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1256 [^]
(0141830)
hgbot   
2022-10-07 09:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c179d152d45b30e236a21ee47333a498c3e8de85
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 07-10-2022 08:55:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c179d152d45b30e236a21ee47333a498c3e8de85 [^]

Fixes ISSUE-50378: Style in Service Provider selector popup filter is wrong

ProductCrossStockList.scss was overwriting one of the styles globally,
instead of only referencing the elements in its popup.

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/ProductCrossStockList.scss
---
(0141831)
hgbot   
2022-10-07 09:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 07c0b0a61d605315cc782a9e0c159b6bd7e7cb10
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 07-10-2022 09:23:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/07c0b0a61d605315cc782a9e0c159b6bd7e7cb10 [^]

Related to ISSUE-50378: Align filters in service provider selector to the left, as other popups do

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/ServiceProviderSelector/ServiceProviderSelector.scss
---