Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050018 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | have not tried | 2022-08-21 11:02 | 2022-10-04 13:44 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050018: Window registration does not support responsive windows | |||||||
| Description | The way application windows are registered, it is not possible to support responsive windows, that is, windows with different layouts that will be selected based on the device orientation. Now when registering a window the second parameter is the specific configuration instance that will be used (see here [1] for example). When that is done, that is the specific configuration that the window will have. In order to support dynamic configurations for windows, instead of passing a specific configuration as a parameter, a configuration name has to be provided. That way when a window is rendered the configuration name can be fetch and then the useConfiguration hook can be used to retrieve the current configuration dynamically, according to the selection function of the configuration set. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/ob-init.js#L291https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/ob-init.js#L291 [^] | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Change the registerApplicationWindow API so that instead of receiving a json object that represents a configuration as a parameter, it receives a configuration name. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0140262) hgbot (developer) 2022-08-21 12:23 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/819 [^] |
|
(0140263) hgbot (developer) 2022-08-21 12:30 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1148 [^] |
|
(0140264) hgbot (developer) 2022-08-21 12:32 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/174 [^] |
|
(0141578) hgbot (developer) 2022-10-03 14:39 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.integration.retail/-/merge_requests/2 [^] |
|
(0141579) hgbot (developer) 2022-10-03 14:46 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/7 [^] |
|
(0141642) hgbot (developer) 2022-10-04 13:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/819 [^] |
|
(0141643) hgbot (developer) 2022-10-04 13:43 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 164eeb12459724088f421b15600207e482056db2 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 04-10-2022 13:41:57 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/164eeb12459724088f421b15600207e482056db2 [^] Fixes ISSUE-50018: Application windows do not support dynamic configurations The API of the Registry.registerApplicationWindow has been updated to accept a configuration name instead of a javascript object that represents a configuration. As a consequence other changes have been done: - Tests and stories have been updated - Registry.checkParameters has been updated to take into account that window are actually stored in an object defined in ApplicationWindow.js and not in Registry.configRegistry - window registrations in ob-init has been updated to take into account new API --- M web-jspack/org.openbravo.core2/src/components/Window/Window.jsx M web-jspack/org.openbravo.core2/src/components/Window/stories/Window.stories.jsx M web-jspack/org.openbravo.core2/src/core/Registry.js M web-jspack/org.openbravo.core2/src/core/__test__/Registry.test.js M web-jspack/org.openbravo.core2/src/ob-init.js --- |
|
(0141644) hgbot (developer) 2022-10-04 13:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1148 [^] |
|
(0141645) hgbot (developer) 2022-10-04 13:43 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: cb89ed705343de38b2e25c3c10dfd8980560f245 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 04-10-2022 13:43:23 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cb89ed705343de38b2e25c3c10dfd8980560f245 [^] Related to ISSUE-50018: Uses new API to register application windows With the new API we have to pass as parameter a configuration name, and ensure that configuration is registered --- M web-jspack/org.openbravo.pos2/src/ob-init.js --- |
|
(0141646) hgbot (developer) 2022-10-04 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: f93f12393aa27d7529179dfbcdc9d2c956e3d4ad Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 03-10-2022 11:24:05 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/f93f12393aa27d7529179dfbcdc9d2c956e3d4ad [^] Related to ISSUE-50018: Uses new API to register application windows With the new API there is no need to overwrite the window configuration, it is enough to overwrite the component configuration --- M web-jspack/org.openbravo.pos2.restaurant/src/ob-init.js --- |
|
(0141647) hgbot (developer) 2022-10-04 13:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/174 [^] |
|
(0141648) hgbot (developer) 2022-10-04 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^] Changeset: 413ebd311abeab083b18bfcca0e1ca40d21b6c77 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 03-10-2022 14:45:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/413ebd311abeab083b18bfcca0e1ca40d21b6c77 [^] Related to ISSUE-50018: Uses new API to register application windows With the new API we have to pass as parameter a configuration name, and ensure that configuration is registered --- M web-jspack/org.openbravo.pos2.service.provider/src/ob-init.js --- |
|
(0141649) hgbot (developer) 2022-10-04 13:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/7 [^] |
|
(0141650) hgbot (developer) 2022-10-04 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.integration.retail [^] Changeset: a979d3921b97273a03457d5dc0e6efec67202faa Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 03-10-2022 14:34:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.integration.retail/-/commit/a979d3921b97273a03457d5dc0e6efec67202faa [^] Related to ISSUE-50018: Uses new API to register application windows With the new API we have to pass as parameter a configuration name, and ensure that configuration is registered --- M web-jspack/org.openbravo.reporting.integration.retail/src/ob-init.js --- |
|
(0141651) hgbot (developer) 2022-10-04 13:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.integration.retail/-/merge_requests/2 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-08-21 11:02 | AugustoMauch | New Issue | |
| 2022-08-21 11:02 | AugustoMauch | Assigned To | => Triage Platform Base |
| 2022-08-21 11:02 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-08-21 11:02 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2022-08-21 11:02 | AugustoMauch | Status | new => scheduled |
| 2022-08-21 12:23 | hgbot | Note Added: 0140262 | |
| 2022-08-21 12:30 | hgbot | Note Added: 0140263 | |
| 2022-08-21 12:32 | hgbot | Note Added: 0140264 | |
| 2022-10-03 14:39 | hgbot | Note Added: 0141578 | |
| 2022-10-03 14:46 | hgbot | Note Added: 0141579 | |
| 2022-10-04 10:49 | ablasco | Relationship added | blocks 0050400 |
| 2022-10-04 13:43 | hgbot | Resolution | open => fixed |
| 2022-10-04 13:43 | hgbot | Status | scheduled => closed |
| 2022-10-04 13:43 | hgbot | Note Added: 0141642 | |
| 2022-10-04 13:43 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-04 13:43 | hgbot | Note Added: 0141643 | |
| 2022-10-04 13:43 | hgbot | Note Added: 0141644 | |
| 2022-10-04 13:43 | hgbot | Note Added: 0141645 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141646 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141647 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141648 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141649 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141650 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141651 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |