Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0050018 | POS2 | Core | public | 2022-08-21 11:02 | 2022-10-04 13:44 |
|
| Reporter | AugustoMauch | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 23Q1 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0050018: Window registration does not support responsive windows |
| Description | The way application windows are registered, it is not possible to support responsive windows, that is, windows with different layouts that will be selected based on the device orientation. Now when registering a window the second parameter is the specific configuration instance that will be used (see here [1] for example). When that is done, that is the specific configuration that the window will have.
In order to support dynamic configurations for windows, instead of passing a specific configuration as a parameter, a configuration name has to be provided. That way when a window is rendered the configuration name can be fetch and then the useConfiguration hook can be used to retrieve the current configuration dynamically, according to the selection function of the configuration set.
[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/ob-init.js#L291https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/ob-init.js#L291 [^] |
| Steps To Reproduce | - |
| Proposed Solution | Change the registerApplicationWindow API so that instead of receiving a json object that represents a configuration as a parameter, it receives a configuration name. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | blocks | feature request | 0050400 | | scheduled | ablasco | Portrait mode support |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-08-21 11:02 | AugustoMauch | New Issue | |
| 2022-08-21 11:02 | AugustoMauch | Assigned To | => Triage Platform Base |
| 2022-08-21 11:02 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-08-21 11:02 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2022-08-21 11:02 | AugustoMauch | Status | new => scheduled |
| 2022-08-21 12:23 | hgbot | Note Added: 0140262 | |
| 2022-08-21 12:30 | hgbot | Note Added: 0140263 | |
| 2022-08-21 12:32 | hgbot | Note Added: 0140264 | |
| 2022-10-03 14:39 | hgbot | Note Added: 0141578 | |
| 2022-10-03 14:46 | hgbot | Note Added: 0141579 | |
| 2022-10-04 10:49 | ablasco | Relationship added | blocks 0050400 |
| 2022-10-04 13:43 | hgbot | Resolution | open => fixed |
| 2022-10-04 13:43 | hgbot | Status | scheduled => closed |
| 2022-10-04 13:43 | hgbot | Note Added: 0141642 | |
| 2022-10-04 13:43 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-04 13:43 | hgbot | Note Added: 0141643 | |
| 2022-10-04 13:43 | hgbot | Note Added: 0141644 | |
| 2022-10-04 13:43 | hgbot | Note Added: 0141645 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141646 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141647 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141648 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141649 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141650 | |
| 2022-10-04 13:44 | hgbot | Note Added: 0141651 | |
|
Notes |
|
|
(0140262)
|
|
hgbot
|
|
2022-08-21 12:23
|
|
|
|
|
(0140263)
|
|
hgbot
|
|
2022-08-21 12:30
|
|
|
|
|
(0140264)
|
|
hgbot
|
|
2022-08-21 12:32
|
|
|
|
|
(0141578)
|
|
hgbot
|
|
2022-10-03 14:39
|
|
|
|
|
(0141579)
|
|
hgbot
|
|
2022-10-03 14:46
|
|
|
|
|
(0141642)
|
|
hgbot
|
|
2022-10-04 13:43
|
|
|
|
|
(0141643)
|
|
hgbot
|
|
2022-10-04 13:43
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 164eeb12459724088f421b15600207e482056db2
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 04-10-2022 13:41:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/164eeb12459724088f421b15600207e482056db2 [^]
Fixes ISSUE-50018: Application windows do not support dynamic configurations
The API of the Registry.registerApplicationWindow has been updated to accept a configuration name instead of a javascript object that represents a configuration. As a consequence other changes have been done:
- Tests and stories have been updated
- Registry.checkParameters has been updated to take into account that window are actually stored in an object defined in ApplicationWindow.js and not in Registry.configRegistry
- window registrations in ob-init has been updated to take into account new API
---
M web-jspack/org.openbravo.core2/src/components/Window/Window.jsx
M web-jspack/org.openbravo.core2/src/components/Window/stories/Window.stories.jsx
M web-jspack/org.openbravo.core2/src/core/Registry.js
M web-jspack/org.openbravo.core2/src/core/__test__/Registry.test.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
|
|
|
|
(0141644)
|
|
hgbot
|
|
2022-10-04 13:43
|
|
|
|
|
(0141645)
|
|
hgbot
|
|
2022-10-04 13:43
|
|
|
|
|
(0141646)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|
|
|
(0141647)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|
|
|
(0141648)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|
|
|
(0141649)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|
|
|
(0141650)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|
|
|
(0141651)
|
|
hgbot
|
|
2022-10-04 13:44
|
|
|