Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049977
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Coreminorhave not tried2022-08-09 11:582022-08-09 12:00
ReporterAugustoMauchView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049977: Buttons which opens popups are focused when popup is closed

DescriptionButtons which opens popups are focused when popup is closed

See this link [https://stackoverflow.com/questions/69047336/material-ui-closing-modal-leaves-focus-state-on-button-that-opened-it [^]]

It causes a problem in POS if after closing a popup a code which includes "whitespaces" is scanned because the button with the focus is pressed again
Steps To ReproduceIn live buids
Login in POS2
In main window add a product to the order
Press delete order button
Close de confirmation popup by pressing cancel or clicking on the background
See that focus is in delete order button again
Press space -> confirmation dialog is shown

When doing a scan with a REAL barcode scanner (cannot be simulated through dev tools console) a space press key event is triggered and the confirm dialog is shown again
Proposed SolutionAdd prop disableRestoreFocus on dialog base component
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0049872 closedmeriem_azaf Buttons which opens popups are focused when popup is closed 

-  Notes
(0140000)
AugustoMauch (manager)
2022-08-09 12:00

Pushed to 22Q3 branch with wrong issue number:

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] [^]
Changeset: 04a65f406d08a6d176b4beac0020cb6f743a9eb3
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 09-08-2022 10:49:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/04a65f406d08a6d176b4beac0020cb6f743a9eb3 [^] [^]

Fixes ISSUE-49872: Buttons which opens popups are focused when popup is closed

Buttons which opens popups are focused when popup is closed.

It causes a problem in POS if after closing a popup a code which includes "whitespaces" is scanned because the button with the focus is pressed again.

To fix this, we added disableRestoreFocus on dialog base component as a prop.

---
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx

- Issue History
Date Modified Username Field Change
2022-08-09 11:58 AugustoMauch New Issue
2022-08-09 11:58 AugustoMauch Assigned To => meriem_azaf
2022-08-09 11:58 AugustoMauch Triggers an Emergency Pack => No
2022-08-09 11:58 AugustoMauch Issue generated from 0049872
2022-08-09 12:00 AugustoMauch Note Added: 0140000
2022-08-09 12:00 AugustoMauch Type defect => backport
2022-08-09 12:00 AugustoMauch Status new => scheduled
2022-08-09 12:00 AugustoMauch Status scheduled => resolved
2022-08-09 12:00 AugustoMauch Resolution open => fixed
2022-08-09 12:00 AugustoMauch Status resolved => closed
2022-08-19 14:16 AugustoMauch Relationship added related to 0049872


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker