Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049872 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | minor | have not tried | 2022-07-22 17:44 | 2022-08-19 14:16 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | meriem_azaf | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049872: Buttons which opens popups are focused when popup is closed | |||||||
| Description | Buttons which opens popups are focused when popup is closed See this link [https://stackoverflow.com/questions/69047336/material-ui-closing-modal-leaves-focus-state-on-button-that-opened-it [^]] It causes a problem in POS if after closing a popup a code which includes "whitespaces" is scanned because the button with the focus is pressed again | |||||||
| Steps To Reproduce | In live buids Login in POS2 In main window add a product to the order Press delete order button Close de confirmation popup by pressing cancel or clicking on the background See that focus is in delete order button again Press space -> confirmation dialog is shown When doing a scan with a REAL barcode scanner (cannot be simulated through dev tools console) a space press key event is triggered and the confirm dialog is shown again | |||||||
| Proposed Solution | Add prop disableRestoreFocus on dialog base component | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0139640) hgbot (developer) 2022-07-27 12:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/806 [^] |
|
(0139932) hgbot (developer) 2022-08-06 11:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 46ae2b2427e0d1e8e3809444e0b8eed0d94143f4 Author: Meriem Azaf <meriem.azaf@openbravo.com> Date: 06-08-2022 11:20:25 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/46ae2b2427e0d1e8e3809444e0b8eed0d94143f4 [^] Fixes ISSUE-49872: Buttons which opens popups are focused when popup is closed Buttons which opens popups are focused when popup is closed. It causes a problem in POS if after closing a popup a code which includes "whitespaces" is scanned because the button with the focus is pressed again. To fix this, we added disableRestoreFocus on dialog base component as a prop. --- M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx --- |
|
(0139933) hgbot (developer) 2022-08-06 11:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/806 [^] |
|
(0139998) hgbot (developer) 2022-08-09 10:50 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 04a65f406d08a6d176b4beac0020cb6f743a9eb3 Author: Meriem Azaf <meriem.azaf@openbravo.com> Date: 09-08-2022 10:49:50 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/04a65f406d08a6d176b4beac0020cb6f743a9eb3 [^] Fixes ISSUE-49872: Buttons which opens popups are focused when popup is closed Buttons which opens popups are focused when popup is closed. It causes a problem in POS if after closing a popup a code which includes "whitespaces" is scanned because the button with the focus is pressed again. To fix this, we added disableRestoreFocus on dialog base component as a prop. --- M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-07-22 17:44 | guilleaer | New Issue | |
| 2022-07-22 17:44 | guilleaer | Assigned To | => Triage Platform Base |
| 2022-07-22 17:44 | guilleaer | Triggers an Emergency Pack | => No |
| 2022-07-22 17:46 | guilleaer | Steps to Reproduce Updated | View Revisions |
| 2022-07-27 08:23 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf |
| 2022-07-27 08:24 | AugustoMauch | Status | new => scheduled |
| 2022-07-27 12:45 | hgbot | Note Added: 0139640 | |
| 2022-08-06 11:52 | hgbot | Resolution | open => fixed |
| 2022-08-06 11:52 | hgbot | Status | scheduled => closed |
| 2022-08-06 11:52 | hgbot | Fixed in Version | => 22Q4 |
| 2022-08-06 11:52 | hgbot | Note Added: 0139932 | |
| 2022-08-06 11:52 | hgbot | Note Added: 0139933 | |
| 2022-08-09 10:50 | hgbot | Fixed in Version | 22Q4 => 22Q3 |
| 2022-08-09 10:50 | hgbot | Note Added: 0139998 | |
| 2022-08-09 11:58 | AugustoMauch | Issue cloned | 0049977 |
| 2022-08-09 12:22 | plujan | Fixed in Version | 22Q3 => 22Q4 |
| 2022-08-19 14:16 | AugustoMauch | Relationship added | related to 0049977 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |