Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049879 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] POS | minor | have not tried | 2022-07-26 21:13 | 2022-08-12 12:27 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049879: Product modifiers of type Text should be available | |||||||
| Description | A new product modifier type should be created to support free text single and multiline input from the user. This new product modifier type is documented in this technical design: https://docs.google.com/document/d/12mEG_8jGzrv1JPcrtcJz26y6OVrMlVWBPbW54gAV4tQ/edit#heading=h.o6c7e168ei4w [^] And also partly documented on the modifiers project technical design: https://docs.google.com/document/d/1EZJ4UPHVoR76z1k7xxbEr_jFiO4DHC19iuvUaxJOhAc/edit#heading=h.84amjg9hmoh5 [^] | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0139623) hgbot (developer) 2022-07-26 22:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1106 [^] |
|
(0139813) hgbot (developer) 2022-08-02 11:44 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/171 [^] |
|
(0140088) hgbot (developer) 2022-08-12 11:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: c4d7097cc046890c1ac0ab2b37fb1f4f1fa06274 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 11:25:39 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c4d7097cc046890c1ac0ab2b37fb1f4f1fa06274 [^] Fixes FR-49879: Product modifiers of type Text should be available This adds support for text modifiers, and also refactors modifiers so it will be easy in the future to add new types of modifiers, without too much extra overhead. --- A src/org/openbravo/pos2/hook/orderloader/TextModifierType.java A src/org/openbravo/pos2/hook/paidreceipt/ProductModifierUtils.java A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/BooleanModifierType.js A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/ModifierType.js A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/ProductModifierTypeRegistry.js A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/RegisterProductModifierTypes.js A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/TextModifierType.js M src-db/database/model/tables/OBPOS2_MODIFIER.xml M src-db/database/model/tables/OBPOS2_ORDERLINE_MODIFIER.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/pos2/hook/paidreceipt/AddProductModifiersPaidReceipts.java M src/org/openbravo/pos2/master/modifier/Modifier.java M web-jspack/org.openbravo.pos2/src/components/ProductConfigurationPanel/ProductConfigurationPanel.scss M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierButton/__test__/ProductModifierButton.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/ProductModifierItemRender.jsx M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/ProductModifierItemRender.scss M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/__test__/ProductModifierItemRender.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierStep.jsx M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierStep.scss M web-jspack/org.openbravo.pos2/src/components/ProductModifier/__mock__/ProductModifierStepData.js M web-jspack/org.openbravo.pos2/src/components/ProductModifier/__test__/ProductModifierStep.test.jsx M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ModifierGroupsConfiguration.js M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/__test__/ModifierGroupsConfiguration.test.js M web-jspack/org.openbravo.pos2/src/model/global/actions/MapProductModifiersToConfiguration.js M web-jspack/org.openbravo.pos2/src/model/modifierGroup/getAvailableModifierGroups.js M web-jspack/org.openbravo.pos2/src/ob-init.js --- |
|
(0140089) hgbot (developer) 2022-08-12 11:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1106 [^] |
|
(0140090) hgbot (developer) 2022-08-12 11:28 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: db5f1b247936e17cf0de6297689757a816ffb345 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 09:28:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/db5f1b247936e17cf0de6297689757a816ffb345 [^] Related to FR-49879: Include modifier text value and type on menu items Also refactors usage of new ModifierType API, which simplifies OrderLoaderHooks and paid receipt hooks. --- M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java --- |
|
(0140091) hgbot (developer) 2022-08-12 11:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/171 [^] |
|
(0140096) hgbot (developer) 2022-08-12 12:27 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: ad5c4b7eb99a92913a4b3278f0c4fda5c123cd13 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 12:25:09 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ad5c4b7eb99a92913a4b3278f0c4fda5c123cd13 [^] Related to FR-49879: Fix issue with GiftCardSaleItemRender test, by using the proper text modifiers Previously text modifiers didn't exist, so the gift card renderer took care of properly handling the gift card information and renderization. That has been simplified with the new text modifier type and as part of it, it will take care of the rendering, so the usage on this module has also been updated. --- M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSaleItemRender.jsx M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/__test__/GiftCardSaleItemRender.test.jsx --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-07-26 21:13 | cberner | New Issue | |
| 2022-07-26 21:13 | cberner | Assigned To | => cberner |
| 2022-07-26 21:13 | cberner | OBNetwork customer | => No |
| 2022-07-26 21:13 | cberner | Triggers an Emergency Pack | => No |
| 2022-07-26 21:13 | cberner | Status | new => scheduled |
| 2022-07-26 22:37 | hgbot | Merge Request Status | => open |
| 2022-07-26 22:37 | hgbot | Note Added: 0139623 | |
| 2022-08-02 11:44 | hgbot | Note Added: 0139813 | |
| 2022-08-12 01:04 | hgbot | Merge Request Status | open => approved |
| 2022-08-12 11:28 | hgbot | Resolution | open => fixed |
| 2022-08-12 11:28 | hgbot | Status | scheduled => closed |
| 2022-08-12 11:28 | hgbot | Fixed in Version | => 22Q4 |
| 2022-08-12 11:28 | hgbot | Note Added: 0140088 | |
| 2022-08-12 11:28 | hgbot | Note Added: 0140089 | |
| 2022-08-12 11:28 | hgbot | Note Added: 0140090 | |
| 2022-08-12 11:28 | hgbot | Note Added: 0140091 | |
| 2022-08-12 12:27 | hgbot | Note Added: 0140096 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |