Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049879POS2POSpublic2022-07-26 21:132022-08-12 12:27
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049879: Product modifiers of type Text should be available
DescriptionA new product modifier type should be created to support free text single and multiline input from the user.

This new product modifier type is documented in this technical design: https://docs.google.com/document/d/12mEG_8jGzrv1JPcrtcJz26y6OVrMlVWBPbW54gAV4tQ/edit#heading=h.o6c7e168ei4w [^]

And also partly documented on the modifiers project technical design: https://docs.google.com/document/d/1EZJ4UPHVoR76z1k7xxbEr_jFiO4DHC19iuvUaxJOhAc/edit#heading=h.84amjg9hmoh5 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-26 21:13cbernerNew Issue
2022-07-26 21:13cbernerAssigned To => cberner
2022-07-26 21:13cbernerTriggers an Emergency Pack => No
2022-07-26 21:13cbernerStatusnew => scheduled
2022-07-26 22:37hgbotNote Added: 0139623
2022-08-02 11:44hgbotNote Added: 0139813
2022-08-12 11:28hgbotResolutionopen => fixed
2022-08-12 11:28hgbotStatusscheduled => closed
2022-08-12 11:28hgbotFixed in Version => 22Q4
2022-08-12 11:28hgbotNote Added: 0140088
2022-08-12 11:28hgbotNote Added: 0140089
2022-08-12 11:28hgbotNote Added: 0140090
2022-08-12 11:28hgbotNote Added: 0140091
2022-08-12 12:27hgbotNote Added: 0140096

Notes
(0139623)
hgbot   
2022-07-26 22:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1106 [^]
(0139813)
hgbot   
2022-08-02 11:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/171 [^]
(0140088)
hgbot   
2022-08-12 11:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c4d7097cc046890c1ac0ab2b37fb1f4f1fa06274
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-08-2022 11:25:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c4d7097cc046890c1ac0ab2b37fb1f4f1fa06274 [^]

Fixes FR-49879: Product modifiers of type Text should be available

This adds support for text modifiers, and also refactors modifiers so it
will be easy in the future to add new types of modifiers, without too
much extra overhead.

---
A src/org/openbravo/pos2/hook/orderloader/TextModifierType.java
A src/org/openbravo/pos2/hook/paidreceipt/ProductModifierUtils.java
A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/BooleanModifierType.js
A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/ModifierType.js
A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/ProductModifierTypeRegistry.js
A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/RegisterProductModifierTypes.js
A web-jspack/org.openbravo.pos2/src/configurations/product-configuration/productModifiers/TextModifierType.js
M src-db/database/model/tables/OBPOS2_MODIFIER.xml
M src-db/database/model/tables/OBPOS2_ORDERLINE_MODIFIER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/pos2/hook/paidreceipt/AddProductModifiersPaidReceipts.java
M src/org/openbravo/pos2/master/modifier/Modifier.java
M web-jspack/org.openbravo.pos2/src/components/ProductConfigurationPanel/ProductConfigurationPanel.scss
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierButton/__test__/ProductModifierButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/ProductModifierItemRender.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/ProductModifierItemRender.scss
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/__test__/ProductModifierItemRender.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierStep.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierStep.scss
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/__mock__/ProductModifierStepData.js
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/__test__/ProductModifierStep.test.jsx
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ModifierGroupsConfiguration.js
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/__test__/ModifierGroupsConfiguration.test.js
M web-jspack/org.openbravo.pos2/src/model/global/actions/MapProductModifiersToConfiguration.js
M web-jspack/org.openbravo.pos2/src/model/modifierGroup/getAvailableModifierGroups.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0140089)
hgbot   
2022-08-12 11:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1106 [^]
(0140090)
hgbot   
2022-08-12 11:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: db5f1b247936e17cf0de6297689757a816ffb345
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-08-2022 09:28:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/db5f1b247936e17cf0de6297689757a816ffb345 [^]

Related to FR-49879: Include modifier text value and type on menu items

Also refactors usage of new ModifierType API, which simplifies OrderLoaderHooks and paid receipt hooks.

---
M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java
---
(0140091)
hgbot   
2022-08-12 11:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/171 [^]
(0140096)
hgbot   
2022-08-12 12:27   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: ad5c4b7eb99a92913a4b3278f0c4fda5c123cd13
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-08-2022 12:25:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ad5c4b7eb99a92913a4b3278f0c4fda5c123cd13 [^]

Related to FR-49879: Fix issue with GiftCardSaleItemRender test, by using the proper text modifiers

Previously text modifiers didn't exist, so the gift card renderer took
care of properly handling the gift card information and renderization.
That has been simplified with the new text modifier type and as part of
it, it will take care of the rendering, so the usage on this module has
also been updated.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSaleItemRender.jsx
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/__test__/GiftCardSaleItemRender.test.jsx
---