Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049877 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Distribution Orders | minor | have not tried | 2022-07-26 16:46 | 2022-08-03 22:51 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0049877: Distribution Orders module is using bad logging (System.out,System.err println or printStackTrace) | |||||||
| Description | This module is using bad logging (printStackTrace) which should fixed (removing it or converting to proper log4j) | |||||||
| Steps To Reproduce | grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c | |||||||
| Proposed Solution | Review and move the logging to proper log4j usage. While doing that check if: - stackTrace is really wanted - Logging is really useful (and not developer leftover) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0139617) hgbot (developer) 2022-07-26 16:54 |
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/12 [^] |
|
(0139862) hgbot (developer) 2022-08-03 22:51 |
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/12 [^] |
|
(0139863) hgbot (developer) 2022-08-03 22:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^] Changeset: 32568268f271b0ab060e77ed662d8ed59a979f26 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 26-07-2022 16:52:44 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/32568268f271b0ab060e77ed662d8ed59a979f26 [^] Fixes ISSUE-49877: Convert printStackTrace to proper log4j Using printStackTrace is bad logging. Convert single leftover case to log4j. --- M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-07-26 16:46 | shuehner | New Issue | |
| 2022-07-26 16:46 | shuehner | Assigned To | => mtaal |
| 2022-07-26 16:46 | shuehner | OBNetwork customer | => No |
| 2022-07-26 16:46 | shuehner | Issue generated from | 0048092 |
| 2022-07-26 16:46 | shuehner | Assigned To | mtaal => shuehner |
| 2022-07-26 16:54 | hgbot | Merge Request Status | => open |
| 2022-07-26 16:54 | hgbot | Note Added: 0139617 | |
| 2022-07-26 16:55 | shuehner | Relationship added | blocks 0036162 |
| 2022-08-03 22:51 | hgbot | Merge Request Status | open => approved |
| 2022-08-03 22:51 | hgbot | Resolution | open => fixed |
| 2022-08-03 22:51 | hgbot | Status | new => closed |
| 2022-08-03 22:51 | hgbot | Note Added: 0139862 | |
| 2022-08-03 22:51 | hgbot | Note Added: 0139863 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |