Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049877ModulesDistribution Orderspublic2022-07-26 16:462022-08-03 22:51
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0049877: Distribution Orders module is using bad logging (System.out,System.err println or printStackTrace)
DescriptionThis module is using bad logging (printStackTrace) which should fixed (removing it or converting to proper log4j)
Steps To Reproducegrep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c

Proposed SolutionReview and move the logging to proper log4j usage.

While doing that check if:
- stackTrace is really wanted
- Logging is really useful (and not developer leftover)
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-26 16:46shuehnerNew Issue
2022-07-26 16:46shuehnerAssigned To => mtaal
2022-07-26 16:46shuehnerIssue generated from0048092
2022-07-26 16:46shuehnerAssigned Tomtaal => shuehner
2022-07-26 16:54hgbotNote Added: 0139617
2022-07-26 16:55shuehnerRelationship addedblocks 0036162
2022-08-03 22:51hgbotResolutionopen => fixed
2022-08-03 22:51hgbotStatusnew => closed
2022-08-03 22:51hgbotNote Added: 0139862
2022-08-03 22:51hgbotNote Added: 0139863

Notes
(0139617)
hgbot   
2022-07-26 16:54   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/12 [^]
(0139862)
hgbot   
2022-08-03 22:51   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/12 [^]
(0139863)
hgbot   
2022-08-03 22:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 32568268f271b0ab060e77ed662d8ed59a979f26
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 26-07-2022 16:52:44
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/32568268f271b0ab060e77ed662d8ed59a979f26 [^]

Fixes ISSUE-49877: Convert printStackTrace to proper log4j

Using printStackTrace is bad logging. Convert single leftover case to
log4j.

---
M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java
---