Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049612 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Restaurants | major | have not tried | 2022-06-21 10:15 | 2022-06-24 14:07 | |||
| Reporter | mmohammad | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049612: FLUN-3089 payment method not ordered in a payment method category | |||||||
| Description | When there are some payment methods in a payment method category, the order of the methods is not correct. Expected result : the methods are ordered by line number Obtained result : the methods are not ordered It seems that specification is not being covered: Buttons Order The order of the buttons will be the same as in WebPOS. It means that first will go all the buttons that have “Channel - Touchpoint -> Payment Type -> Line No.” defined (lower “Line No.” will mean that they go in first positions), and after that, all the “Payment Type” with no “Line No.” defined in alphabetical order. In case there is a “Payment Type” that belongs to a “POS Payment Method Category”, instead of this payment method button, it should draw the “Payment Method Category” button that will open a popup with all the payment methods belonging to that “Payment Method Category”. Of course, the “Payment Method Category” will be only displayed once, and in that position where the first “Payment Type” should be. After pressing a “Payment Method Category” category button, a popup should be opened with all the payment method buttons belonging to this “Payment Method Category”, sorted under the same criteria explained in the previous paragraph. | |||||||
| Steps To Reproduce | setup a Terminal POs by adding line number to payment methods on a same category. For example : TICKET CRT =60 and TICKET ANCV=61 in pos 69_03. Expected result : TICKET CRT is displayed fisrt on the category TICKET RESTAURANT See the obtained result : the line number is not considered | |||||||
| Proposed Solution | TO-DO list to fix this (Javier Rodriguez) : Create configuration to have the same scenario than the Jira description Check order in payment initial grid (It should be working as expected) Check order in payment method category popup Proposal solution: In PaymentMethodsHighVolumePanel component: Refactor generatePaymentButton to include inside the structure a new attribute which is the lineNo Refactor generatePaymentMethodsFromCategory to sort the buttons depending on the rules defined in the functional document, page 4 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  PaymentMEthodCategory.jpg [^] (51,821 bytes) 2022-06-21 10:15
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0138706) hgbot (developer) 2022-06-23 17:28 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1034 [^] |
|
(0138756) hgbot (developer) 2022-06-24 14:07 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1034 [^] |
|
(0138757) hgbot (developer) 2022-06-24 14:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 6819934758feae6047ee9ae9a3f12de485e6b40f Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 24-06-2022 14:05:07 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6819934758feae6047ee9ae9a3f12de485e6b40f [^] Fixed ISSUE-49612: Ordering properly the payment methods contained inside a payment category --- A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodsHighVolumePanel/orderByLineAndName.js A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/orderByLineAndName.test.js M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodsHighVolumePanel/PaymentMethodsHighVolumePanel.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/componentsListSnapshot.json M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__mock__/payments.json --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-06-21 10:15 | mmohammad | New Issue | |
| 2022-06-21 10:15 | mmohammad | Assigned To | => Retail |
| 2022-06-21 10:15 | mmohammad | File Added: PaymentMEthodCategory.jpg | |
| 2022-06-21 10:15 | mmohammad | Triggers an Emergency Pack | => No |
| 2022-06-23 15:58 | jarmendariz | Status | new => scheduled |
| 2022-06-23 15:58 | jarmendariz | Assigned To | Retail => jarmendariz |
| 2022-06-23 17:28 | hgbot | Note Added: 0138706 | |
| 2022-06-24 14:07 | hgbot | Resolution | open => fixed |
| 2022-06-24 14:07 | hgbot | Status | scheduled => closed |
| 2022-06-24 14:07 | hgbot | Note Added: 0138756 | |
| 2022-06-24 14:07 | hgbot | Note Added: 0138757 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |