Openbravo Issue Tracking System - POS2
View Issue Details
0049612POS2Restaurantspublic2022-06-21 10:152022-06-24 14:07
mmohammad 
jarmendariz 
normalmajorhave not tried
closedfixed 
5
 
 
approved
No
No
0049612: FLUN-3089 payment method not ordered in a payment method category
When there are some payment methods in a payment method category, the order of the methods is not correct.

 

Expected result : the methods are ordered by line number

Obtained result : the methods are not ordered

It seems that specification is not being covered:

Buttons Order

The order of the buttons will be the same as in WebPOS. It means that first will go all the buttons that have “Channel - Touchpoint -> Payment Type -> Line No.” defined (lower “Line No.” will mean that they go in first positions), and after that, all the “Payment Type” with no “Line No.” defined in alphabetical order.

In case there is a “Payment Type” that belongs to a “POS Payment Method Category”, instead of this payment method button, it should draw the “Payment Method Category” button that will open a popup with all the payment methods belonging to that “Payment Method Category”. Of course, the “Payment Method Category” will be only displayed once, and in that position where the first “Payment Type” should be.

After pressing a “Payment Method Category” category button, a popup should be opened with all the payment method buttons belonging to this “Payment Method Category”, sorted under the same criteria explained in the previous paragraph.

 
setup a Terminal POs by adding line number to payment methods on a same category.

For example : TICKET CRT =60 and TICKET ANCV=61 in pos 69_03.

Expected result : TICKET CRT is displayed fisrt on the category TICKET RESTAURANT

See the obtained result : the line number is not considered
TO-DO list to fix this (Javier Rodriguez) :

Create configuration to have the same scenario than the Jira description

Check order in payment initial grid (It should be working as expected)

Check order in payment method category popup

Proposal solution:

In PaymentMethodsHighVolumePanel component:

Refactor generatePaymentButton to include inside the structure a new attribute which is the lineNo

Refactor generatePaymentMethodsFromCategory to sort the buttons depending on the rules defined in the functional document, page 4
No tags attached.
jpg PaymentMEthodCategory.jpg (51,821) 2022-06-21 10:15
https://issues.openbravo.com/file_download.php?file_id=17199&type=bug
jpg
Issue History
2022-06-21 10:15mmohammadNew Issue
2022-06-21 10:15mmohammadAssigned To => Retail
2022-06-21 10:15mmohammadFile Added: PaymentMEthodCategory.jpg
2022-06-21 10:15mmohammadOBNetwork customer => No
2022-06-21 10:15mmohammadTriggers an Emergency Pack => No
2022-06-23 15:58jarmendarizStatusnew => scheduled
2022-06-23 15:58jarmendarizAssigned ToRetail => jarmendariz
2022-06-23 17:28hgbotMerge Request Status => open
2022-06-23 17:28hgbotNote Added: 0138706
2022-06-23 22:52hgbotMerge Request Statusopen => approved
2022-06-23 23:59hgbotMerge Request Statusapproved => open
2022-06-24 14:04hgbotMerge Request Statusopen => approved
2022-06-24 14:07hgbotResolutionopen => fixed
2022-06-24 14:07hgbotStatusscheduled => closed
2022-06-24 14:07hgbotNote Added: 0138756
2022-06-24 14:07hgbotNote Added: 0138757

Notes
(0138706)
hgbot   
2022-06-23 17:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1034 [^]
(0138756)
hgbot   
2022-06-24 14:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1034 [^]
(0138757)
hgbot   
2022-06-24 14:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6819934758feae6047ee9ae9a3f12de485e6b40f
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 24-06-2022 14:05:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6819934758feae6047ee9ae9a3f12de485e6b40f [^]

Fixed ISSUE-49612: Ordering properly the payment methods contained inside a payment category

---
A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodsHighVolumePanel/orderByLineAndName.js
A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/orderByLineAndName.test.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodsHighVolumePanel/PaymentMethodsHighVolumePanel.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/componentsListSnapshot.json
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__mock__/payments.json
---