Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049532 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2022-06-10 12:32 | 2022-07-07 13:36 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | radhakrishnan | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR22Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049532: Illegal reference from business logic application to Enyo WebPOS code | |||||||
| Description | After the merge of 0049409, we found an illegal reference from business logic app to Enyo WebPOS code. This is not correct, and should be fixed. | |||||||
| Steps To Reproduce | Here: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/92f5b4c5e67b08eda469d2d97ff1f07a4cf0ae03#94769f7911f29745f508a4b52ca811a03b66e96b_78_56 [^] There is a reference from CompleteMultiTicketUtils.js, to the function OB.UTIL.getDefaultCashPaymentMethod(), which is defined in Enyo WebPOS code. | |||||||
| Proposed Solution | Function OB.UTIL.getDefaultCashPaymentMethod() should be moved to one of the utility files defined in business logic app. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0138594) hgbot (developer) 2022-06-21 13:35 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/830 [^] |
|
(0138678) hgbot (developer) 2022-06-23 09:58 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/830 [^] |
|
(0138679) hgbot (developer) 2022-06-23 09:58 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 7b729076947014b01ba4e9697ec647166ef66c91 Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com> Date: 23-06-2022 07:03:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b729076947014b01ba4e9697ec647166ef66c91 [^] Fixed ISSUE-49532: Function getDefaultCashPaymentMethod moved to ticket utils --- M web-test/model/business-object/ticket/actions/CompleteMultiTicket.test.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteMultiTicketUtils.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js --- |
|
(0138680) hgbot (developer) 2022-06-23 09:58 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: f79e43fc78c3a5fdf1316f05517d501e28abec67 Author: Antonio Moreno <antonio.moreno@openbravo.com> Date: 23-06-2022 09:58:08 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f79e43fc78c3a5fdf1316f05517d501e28abec67 [^] Related to ISSUE-49532: added return statement to ensure the default payment method is returned in original function --- M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-06-10 12:32 | marvintm | New Issue | |
| 2022-06-10 12:32 | marvintm | Assigned To | => Retail |
| 2022-06-10 12:32 | marvintm | Triggers an Emergency Pack | => No |
| 2022-06-10 13:29 | jorgewederago | Issue Monitored: jorgewederago | |
| 2022-06-13 08:07 | marvintm | Status | new => scheduled |
| 2022-06-13 08:07 | marvintm | Assigned To | Retail => radhakrishnan |
| 2022-06-21 13:35 | hgbot | Note Added: 0138594 | |
| 2022-06-23 09:58 | hgbot | Resolution | open => fixed |
| 2022-06-23 09:58 | hgbot | Status | scheduled => closed |
| 2022-06-23 09:58 | hgbot | Note Added: 0138678 | |
| 2022-06-23 09:58 | hgbot | Fixed in Version | => RR22Q3 |
| 2022-06-23 09:58 | hgbot | Note Added: 0138679 | |
| 2022-06-23 09:58 | hgbot | Note Added: 0138680 | |
| 2022-07-07 13:36 | plujan | Description Updated | View Revisions |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |