Openbravo Issue Tracking System - Retail Modules
View Issue Details
0049532Retail ModulesWeb POSpublic2022-06-10 12:322022-07-07 13:36
marvintm 
radhakrishnan 
normalmajorhave not tried
closedfixed 
5
 
RR22Q3 
No
0049532: Illegal reference from business logic application to Enyo WebPOS code
After the merge of 0049409, we found an illegal reference from business logic app to Enyo WebPOS code.

This is not correct, and should be fixed.
Here:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/92f5b4c5e67b08eda469d2d97ff1f07a4cf0ae03#94769f7911f29745f508a4b52ca811a03b66e96b_78_56 [^]

There is a reference from CompleteMultiTicketUtils.js, to the function OB.UTIL.getDefaultCashPaymentMethod(), which is defined in Enyo WebPOS code.
Function OB.UTIL.getDefaultCashPaymentMethod() should be moved to one of the utility files defined in business logic app.
No tags attached.
Issue History
2022-06-10 12:32marvintmNew Issue
2022-06-10 12:32marvintmAssigned To => Retail
2022-06-10 12:32marvintmTriggers an Emergency Pack => No
2022-06-10 13:29jorgewederagoIssue Monitored: jorgewederago
2022-06-13 08:07marvintmStatusnew => scheduled
2022-06-13 08:07marvintmAssigned ToRetail => radhakrishnan
2022-06-21 13:35hgbotNote Added: 0138594
2022-06-23 09:58hgbotResolutionopen => fixed
2022-06-23 09:58hgbotStatusscheduled => closed
2022-06-23 09:58hgbotNote Added: 0138678
2022-06-23 09:58hgbotFixed in Version => RR22Q3
2022-06-23 09:58hgbotNote Added: 0138679
2022-06-23 09:58hgbotNote Added: 0138680
2022-07-07 13:36plujanDescription Updatedbug_revision_view_page.php?rev_id=24443#r24443

Notes
(0138594)
hgbot   
2022-06-21 13:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/830 [^]
(0138678)
hgbot   
2022-06-23 09:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/830 [^]
(0138679)
hgbot   
2022-06-23 09:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7b729076947014b01ba4e9697ec647166ef66c91
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 23-06-2022 07:03:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b729076947014b01ba4e9697ec647166ef66c91 [^]

Fixed ISSUE-49532: Function getDefaultCashPaymentMethod moved to ticket utils

---
M web-test/model/business-object/ticket/actions/CompleteMultiTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteMultiTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0138680)
hgbot   
2022-06-23 09:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f79e43fc78c3a5fdf1316f05517d501e28abec67
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 23-06-2022 09:58:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f79e43fc78c3a5fdf1316f05517d501e28abec67 [^]

Related to ISSUE-49532: added return statement to ensure the default payment method is returned in original function

---
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---