Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049500
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2022-06-07 17:422022-06-27 12:19
ReportervmromanosView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionopenFixed in Version
StatusscheduledFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049500: Preference visibility in other clients

DescriptionIn an instance with several clients, the preferences defined in one client can affected other clients.
Steps To ReproduceUse any instance with several clients, like https://livebuilds.openbravo.com/retail_modules_oracle_pi [^]
Login in backoffice and go to WhiteValley client
Create the following preference:
 Client: The White Valley Group
 Org: *
 Property List: Y
 Property: Allow Goods Transaction outside AWO for Inventories
 Value: Y
 Leave empty all the fields in Visibility field group

Information: with this preference we are allowing to manually process physical inventories outside AWO.

Now change the role to AWO-QA Admin (in AWO client, which is different from White Valley)
Go to Physical Inventory and create a new record:
 Org: US West Coast
 Warehouse: US West Coast
Enter a new line:
 Product: ISSalesAWOTest0001
 Bin: ISSalesAWOTest0001
 Quantity Count: 99
Process Inventory Count. Verify the record is processed successfully, however an exception should be thrown instead!

Go back to WhiteValley client and remove the previous preference.

Go back to AWO-QA client and create the same Physical Inventory, but setting Quantity Count: 100.
Process Inventory Count. Verify an exception is thrown. This is the expected behavior. So the preference in the WhiteValley client is impacting the AWO-QA client.
   
Proposed SolutionThe problem is with the Visible At Client field. When you leave it empty in the preference definition, the AD_GET_PREFERENCE_VALUE is bypassing this field:

and (visibleat_client_id = v_ad_client_id
                or coalesce(visibleat_client_id, '0') = '0')

I honestly think this Visible At Client field has no sense and it should be removed. Instead we should do the following logic:
* You are able to see the preferences defined at your client AND the ones defined at System level.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0138126)
hgbot (developer)
2022-06-07 19:09

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: dea4408d031cf92ad4698eef69a63e8b5419d8ec
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 07-06-2022 18:58:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/dea4408d031cf92ad4698eef69a63e8b5419d8ec [^]

Related to ISSUE-49500: Force to set the visible at client to workaround issue

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookUtils.java
---
(0138127)
hgbot (developer)
2022-06-07 19:09

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 99dda422c1c5a94be5444e095456eb2ac84d4c90
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 07-06-2022 19:09:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/99dda422c1c5a94be5444e095456eb2ac84d4c90 [^]

Related to ISSUE-49500: enable tests again as there is a workaround in

org.openbravo.warehouse.advancedwarehouseoperations.api that sets the
visible at client property when creating the preference

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOb_BasicFunctionalFlowsWithAWOPreference.java
---
(0138781)
hgbot (developer)
2022-06-27 12:19

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/630 [^]

- Issue History
Date Modified Username Field Change
2022-06-07 17:42 vmromanos New Issue
2022-06-07 17:42 vmromanos Assigned To => Triage Platform Base
2022-06-07 17:42 vmromanos Modules => Core
2022-06-07 17:42 vmromanos Triggers an Emergency Pack => No
2022-06-07 19:09 hgbot Note Added: 0138126
2022-06-07 19:09 hgbot Note Added: 0138127
2022-06-23 22:24 AugustoMauch Assigned To Triage Platform Base => ablasco
2022-06-23 22:24 AugustoMauch Status new => scheduled
2022-06-27 12:19 hgbot Note Added: 0138781


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker