0049500: Preference visibility in other clients - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049500

Openbravo ERP

A. Platform

public

2022-06-07 17:42

2022-07-12 09:03

Reporter

vmromanos

Assigned To

ablasco

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

PR22Q4

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049500: Preference visibility in other clients

Description

In an instance with several clients, the preferences defined in one client can affected other clients.

Steps To Reproduce

Use any instance with several clients, like https://livebuilds.openbravo.com/retail_modules_oracle_pi [^]
Login in backoffice and go to WhiteValley client
Create the following preference:
Client: The White Valley Group
Org: *
Property List: Y
Property: Allow Goods Transaction outside AWO for Inventories
Value: Y
Leave empty all the fields in Visibility field group

Information: with this preference we are allowing to manually process physical inventories outside AWO.

Now change the role to AWO-QA Admin (in AWO client, which is different from White Valley)
Go to Physical Inventory and create a new record:
Org: US West Coast
Warehouse: US West Coast
Enter a new line:
Product: ISSalesAWOTest0001
Bin: ISSalesAWOTest0001
Quantity Count: 99
Process Inventory Count. Verify the record is processed successfully, however an exception should be thrown instead!

Go back to WhiteValley client and remove the previous preference.

Go back to AWO-QA client and create the same Physical Inventory, but setting Quantity Count: 100.
Process Inventory Count. Verify an exception is thrown. This is the expected behavior. So the preference in the WhiteValley client is impacting the AWO-QA client.

Proposed Solution

The problem is with the Visible At Client field. When you leave it empty in the preference definition, the AD_GET_PREFERENCE_VALUE is bypassing this field:

and (visibleat_client_id = v_ad_client_id
or coalesce(visibleat_client_id, '0') = '0')

I honestly think this Visible At Client field has no sense and it should be removed. Instead we should do the following logic:
* You are able to see the preferences defined at your client AND the ones defined at System level.

Additional Information