Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049452 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-05-31 16:23 | 2022-06-02 10:46 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049452: Ripple effect in product buttons have a bad performance impact | |||||||
| Description | We noticed than the performance of the addProduct action is shighly impacted by the ripple effect defined for BaseButtons [1]. We took some measurements and for instance adding a product that has product modifiers takes ~1.1 seconds if the ripple effect is enabled, and ~0.3 seconds if the effect is removed from the scss file. Also see the two attached images to notive the extra computation done when the effect is enabled. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.scss#L72 [^] | |||||||
| Steps To Reproduce | Add a product that has modifiers (i.e. Cheeseburguer) with, and without the ripple effect. You will notice that if the effect is enabled the product configuration window will take much longer to open. Also if you run chrome debugger's profile while you add the products, you will notice the extra computation done (see attached files). | |||||||
| Proposed Solution | Disable the ripple effect for the ProductButtons. It can remain in other buttons ebceuase their performance does not seem to be impacted | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  withEffect.png [^] (16,368 bytes) 2022-05-31 16:24
withoutEffect.png [^] (16,654 bytes) 2022-05-31 16:24
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0137930) hgbot (developer) 2022-06-01 11:04 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/981 [^] |
|
(0137964) hgbot (developer) 2022-06-02 10:45 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 6bd293bf6e21159e57933588749638bf9c54319c Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 02-06-2022 09:28:51 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6bd293bf6e21159e57933588749638bf9c54319c [^] Fixed ISSUE-49452: Removing ripple effect on product button for performance reasons --- M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButton.scss --- |
|
(0137965) hgbot (developer) 2022-06-02 10:46 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/981 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-05-31 16:23 | AugustoMauch | New Issue | |
| 2022-05-31 16:23 | AugustoMauch | Assigned To | => jarmendariz |
| 2022-05-31 16:23 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-05-31 16:24 | AugustoMauch | File Added: withEffect.png | |
| 2022-05-31 16:24 | AugustoMauch | File Added: withoutEffect.png | |
| 2022-05-31 16:26 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2022-05-31 16:26 | AugustoMauch | Status | new => scheduled |
| 2022-06-01 11:04 | hgbot | Note Added: 0137930 | |
| 2022-06-02 10:45 | hgbot | Resolution | open => fixed |
| 2022-06-02 10:45 | hgbot | Status | scheduled => closed |
| 2022-06-02 10:45 | hgbot | Note Added: 0137964 | |
| 2022-06-02 10:46 | hgbot | Note Added: 0137965 | |
| 2022-06-02 17:18 | AugustoMauch | Relationship added | has duplicate 0049402 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |