Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049452POS2POSpublic2022-05-31 16:232022-06-02 10:46
ReporterAugustoMauch 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049452: Ripple effect in product buttons have a bad performance impact
DescriptionWe noticed than the performance of the addProduct action is shighly impacted by the ripple effect defined for BaseButtons [1].

We took some measurements and for instance adding a product that has product modifiers takes ~1.1 seconds if the ripple effect is enabled, and ~0.3 seconds if the effect is removed from the scss file.

Also see the two attached images to notive the extra computation done when the effect is enabled.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.scss#L72 [^]
Steps To ReproduceAdd a product that has modifiers (i.e. Cheeseburguer) with, and without the ripple effect. You will notice that if the effect is enabled the product configuration window will take much longer to open.

Also if you run chrome debugger's profile while you add the products, you will notice the extra computation done (see attached files).
Proposed SolutionDisable the ripple effect for the ProductButtons. It can remain in other buttons ebceuase their performance does not seem to be impacted
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0049402 closed AugustoMauch JIRA 3018 : [Latencies] Adding a product with modifier 
Attached Filespng withEffect.png (16,368) 2022-05-31 16:24
https://issues.openbravo.com/file_download.php?file_id=17097&type=bug
png

png withoutEffect.png (16,654) 2022-05-31 16:24
https://issues.openbravo.com/file_download.php?file_id=17098&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-05-31 16:23AugustoMauchNew Issue
2022-05-31 16:23AugustoMauchAssigned To => jarmendariz
2022-05-31 16:23AugustoMauchTriggers an Emergency Pack => No
2022-05-31 16:24AugustoMauchFile Added: withEffect.png
2022-05-31 16:24AugustoMauchFile Added: withoutEffect.png
2022-05-31 16:26AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24203#r24203
2022-05-31 16:26AugustoMauchStatusnew => scheduled
2022-06-01 11:04hgbotNote Added: 0137930
2022-06-02 10:45hgbotResolutionopen => fixed
2022-06-02 10:45hgbotStatusscheduled => closed
2022-06-02 10:45hgbotNote Added: 0137964
2022-06-02 10:46hgbotNote Added: 0137965
2022-06-02 17:18AugustoMauchRelationship addedhas duplicate 0049402

Notes
(0137930)
hgbot   
2022-06-01 11:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/981 [^]
(0137964)
hgbot   
2022-06-02 10:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6bd293bf6e21159e57933588749638bf9c54319c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-06-2022 09:28:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6bd293bf6e21159e57933588749638bf9c54319c [^]

Fixed ISSUE-49452: Removing ripple effect on product button for performance reasons

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButton.scss
---
(0137965)
hgbot   
2022-06-02 10:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/981 [^]