Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049447
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] External Integration Infrastructuremajoralways2022-05-31 14:132022-06-02 09:01
Reporterleyre-iriarteView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3af99ef74db54d8ec9ba8a0938e4ded5ced3aff4 [^]
Regression level
Review Assigned To
Regression introduced in release
Summary

0049447: Synch EDL returns an Null pointer exception

DescriptionWhen creating a synch EDL, without configuration (window EDL Configuration), there is an "Unhandled exception".
In ProcessRequest 798, the type on syncronitation of the EDL is check but also if there is an error of configuration. In this case is false so the flow goes to a Asynch EDL (line 826). The asynchProcessor is not initialized therefore the flows fails.
Also configurationErrorMessage contains the response of the configuration (checked in method configurationValidations()), but again in lines 801-807 the configuration is retreived again.
Steps To Reproduce1. Throw any SYNCH EDL with NO configuration
2. A EDL Request is crated with Respose java.lang.NullPointerException.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137947)
hgbot (developer)
2022-06-01 17:12

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/21 [^]
(0137959)
hgbot (developer)
2022-06-02 09:01

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/21 [^]
(0137960)
hgbot (developer)
2022-06-02 09:01

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 5332d6c6366bf82f8354e03bd4cdc9cca889bd22
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 01-06-2022 17:14:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/5332d6c6366bf82f8354e03bd4cdc9cca889bd22 [^]

fixes BUG-49447: NPE when adding sync request with missing output config

  A NPE exception was thrown when adding a request for a synchronous EDL
process configured with output but having no output configuration.

  The NPE was thrown because the synchronous processing is correctly
skipped but then we are wrongly entering into the async flow due to an
incorrect else clause.

  Now the addRequest still fails in this case, but instead of a NPE a
controlled OBException is thrown and the EDL request is created in error
status with the correct error message in the response field.

---
M src-test/org/openbravo/externaldata/integration/process/AddRequestTest.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---

- Issue History
Date Modified Username Field Change
2022-05-31 14:13 leyre-iriarte New Issue
2022-05-31 14:13 leyre-iriarte Assigned To => Triage Platform Conn
2022-05-31 14:13 leyre-iriarte Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3af99ef74db54d8ec9ba8a0938e4ded5ced3aff4 [^]
2022-05-31 14:41 adrianromero Assigned To Triage Platform Conn => caristu
2022-05-31 14:42 adrianromero Status new => acknowledged
2022-05-31 14:42 adrianromero Status acknowledged => scheduled
2022-06-01 17:12 hgbot Note Added: 0137947
2022-06-02 09:01 hgbot Note Added: 0137959
2022-06-02 09:01 hgbot Resolution open => fixed
2022-06-02 09:01 hgbot Status scheduled => closed
2022-06-02 09:01 hgbot Note Added: 0137960


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker