Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049447ModulesExternal Integration Infrastructurepublic2022-05-31 14:132022-06-02 09:01
Reporterleyre-iriarte 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3af99ef74db54d8ec9ba8a0938e4ded5ced3aff4 [^]
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0049447: Synch EDL returns an Null pointer exception
DescriptionWhen creating a synch EDL, without configuration (window EDL Configuration), there is an "Unhandled exception".
In ProcessRequest 798, the type on syncronitation of the EDL is check but also if there is an error of configuration. In this case is false so the flow goes to a Asynch EDL (line 826). The asynchProcessor is not initialized therefore the flows fails.
Also configurationErrorMessage contains the response of the configuration (checked in method configurationValidations()), but again in lines 801-807 the configuration is retreived again.
Steps To Reproduce1. Throw any SYNCH EDL with NO configuration
2. A EDL Request is crated with Respose java.lang.NullPointerException.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-31 14:13leyre-iriarteNew Issue
2022-05-31 14:13leyre-iriarteAssigned To => Triage Platform Conn
2022-05-31 14:13leyre-iriarteRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3af99ef74db54d8ec9ba8a0938e4ded5ced3aff4 [^]
2022-05-31 14:41adrianromeroAssigned ToTriage Platform Conn => caristu
2022-05-31 14:42adrianromeroStatusnew => acknowledged
2022-05-31 14:42adrianromeroStatusacknowledged => scheduled
2022-06-01 17:12hgbotNote Added: 0137947
2022-06-02 09:01hgbotNote Added: 0137959
2022-06-02 09:01hgbotResolutionopen => fixed
2022-06-02 09:01hgbotStatusscheduled => closed
2022-06-02 09:01hgbotNote Added: 0137960

Notes
(0137947)
hgbot   
2022-06-01 17:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/21 [^]
(0137959)
hgbot   
2022-06-02 09:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/21 [^]
(0137960)
hgbot   
2022-06-02 09:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 5332d6c6366bf82f8354e03bd4cdc9cca889bd22
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 01-06-2022 17:14:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/5332d6c6366bf82f8354e03bd4cdc9cca889bd22 [^]

fixes BUG-49447: NPE when adding sync request with missing output config

  A NPE exception was thrown when adding a request for a synchronous EDL
process configured with output but having no output configuration.

  The NPE was thrown because the synchronous processing is correctly
skipped but then we are wrongly entering into the async flow due to an
incorrect else clause.

  Now the addRequest still fails in this case, but instead of a NPE a
controlled OBException is thrown and the EDL request is created in error
status with the correct error message in the response field.

---
M src-test/org/openbravo/externaldata/integration/process/AddRequestTest.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---