Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049429
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2022-05-27 13:292022-06-01 11:47
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049429: Filterbar: selecting empty value in fitlerbar combo filter gives js error

DescriptionSee attached screenshots.
Steps To ReproduceTo reproduce open a grid with a filterbar and a filter field which is a combobox. Select a non-empty value in the filter. Filtering happens. Then select the empty value in the filter field --> error
Proposed SolutionCheck in the code here [1] if value is a set, if not then do not do the length check (which assumes a string of length>0 anyway).


[1]
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx#L71 [^]
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2022-05-27 13-25-43.png [^] (160,198 bytes) 2022-05-27 13:29


png file icon Screenshot from 2022-05-27 13-26-18.png [^] (67,402 bytes) 2022-05-27 13:29

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137815)
hgbot (developer)
2022-05-27 13:38

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/759 [^]
(0137935)
hgbot (developer)
2022-06-01 11:45

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 79e813098e8a0a8cfd151732d190910f29c2dd95
Author: Martin Taal <martin.taal@openbravo.com>
Date: 01-06-2022 09:45:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/79e813098e8a0a8cfd151732d190910f29c2dd95 [^]

Fixes ISSUE-49429: prevent JS error when selecting empty combobox option in filter

---
M web-jspack/org.openbravo.core2/src/components/ComboBox/__test__/selectComboBoxOption.js
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/__test__/FilterBar.test.jsx
---
(0137936)
hgbot (developer)
2022-06-01 11:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/759 [^]

- Issue History
Date Modified Username Field Change
2022-05-27 13:29 mtaal New Issue
2022-05-27 13:29 mtaal Assigned To => mtaal
2022-05-27 13:29 mtaal File Added: Screenshot from 2022-05-27 13-25-43.png
2022-05-27 13:29 mtaal Triggers an Emergency Pack => No
2022-05-27 13:29 mtaal File Added: Screenshot from 2022-05-27 13-26-18.png
2022-05-27 13:38 hgbot Note Added: 0137815
2022-05-27 13:39 mtaal Status new => scheduled
2022-05-27 13:39 mtaal Status scheduled => resolved
2022-05-27 13:39 mtaal Resolution open => fixed
2022-06-01 11:45 hgbot Note Added: 0137935
2022-06-01 11:45 hgbot Note Added: 0137936
2022-06-01 11:47 caristu Review Assigned To => caristu
2022-06-01 11:47 caristu Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker