Openbravo Issue Tracking System - POS2
View Issue Details
0049429POS2Corepublic2022-05-27 13:292022-06-01 11:47
mtaal 
mtaal 
normalminorhave not tried
closedfixed 
5
 
 
caristu
No
0049429: Filterbar: selecting empty value in fitlerbar combo filter gives js error
See attached screenshots.
To reproduce open a grid with a filterbar and a filter field which is a combobox. Select a non-empty value in the filter. Filtering happens. Then select the empty value in the filter field --> error
Check in the code here [1] if value is a set, if not then do not do the length check (which assumes a string of length>0 anyway).


[1]
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx#L71 [^]
No tags attached.
png Screenshot from 2022-05-27 13-25-43.png (160,198) 2022-05-27 13:29
https://issues.openbravo.com/file_download.php?file_id=17073&type=bug
png

png Screenshot from 2022-05-27 13-26-18.png (67,402) 2022-05-27 13:29
https://issues.openbravo.com/file_download.php?file_id=17074&type=bug
png
Issue History
2022-05-27 13:29mtaalNew Issue
2022-05-27 13:29mtaalAssigned To => mtaal
2022-05-27 13:29mtaalFile Added: Screenshot from 2022-05-27 13-25-43.png
2022-05-27 13:29mtaalTriggers an Emergency Pack => No
2022-05-27 13:29mtaalFile Added: Screenshot from 2022-05-27 13-26-18.png
2022-05-27 13:38hgbotNote Added: 0137815
2022-05-27 13:39mtaalStatusnew => scheduled
2022-05-27 13:39mtaalStatusscheduled => resolved
2022-05-27 13:39mtaalResolutionopen => fixed
2022-06-01 11:45hgbotNote Added: 0137935
2022-06-01 11:45hgbotNote Added: 0137936
2022-06-01 11:47caristuReview Assigned To => caristu
2022-06-01 11:47caristuStatusresolved => closed

Notes
(0137815)
hgbot   
2022-05-27 13:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/759 [^]
(0137935)
hgbot   
2022-06-01 11:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 79e813098e8a0a8cfd151732d190910f29c2dd95
Author: Martin Taal <martin.taal@openbravo.com>
Date: 01-06-2022 09:45:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/79e813098e8a0a8cfd151732d190910f29c2dd95 [^]

Fixes ISSUE-49429: prevent JS error when selecting empty combobox option in filter

---
M web-jspack/org.openbravo.core2/src/components/ComboBox/__test__/selectComboBoxOption.js
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/__test__/FilterBar.test.jsx
---
(0137936)
hgbot   
2022-06-01 11:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/759 [^]